Page MenuHomePhabricator

Watchlist Expiry: Add a popup to watch pages temporarily - BEING WORKED ON IN SEPARATE SUBTASKS
Closed, ResolvedPublic

Description

As a Watchlist Expiry user, I want a popup to appear when I watch a page (temporarily or permanently), so that I can see the expiry selection and make any necessary changes.

Background: We might need to hash out the loading animations (for "watch" action + for loading OOUI) and hash out some more behavior, like how long the popup appears if action was taken or not, what messages appear first and then later, etc. Note that we are adding the half star functionality in T248495. For conversations related to drop-down behavior, you can also check out T245565 for details.

Resources:

Acceptance Criteria:

  • On click of the 'watch' button, first watch the page as usual (permanently)
  • Lazy-load the popup that allows users to set the page to be watched temporarily
    • The user will first see the following message at the top: [page name] and its talk page have been added to your watchlist permanently
    • Label has the name "Watchlist Time Period:" above drop-down
    • The drop-down has the following options:
      • Permanently (as default)
      • 1 week
      • 1 month
      • 3 months
      • 6 months
  • Implement functionality and behavior after selection chosen
    • If a temporary span was chosen, adjust the watch state of the page to have an expiry
    • Behavior of the popup at the end of the process:
      • If the user keeps default selection ("permanently"), the popup should disappear after X seconds
      • If the user changed the selection, the following behavior should occur:
        • The full star rotates and becomes half star (see half star details in T248495)
        • Display a success message: [page name] and its talk page have been added to your watchlist [time period, such as "one week"]
  • The word "watchlist" in the pop-up should always link to the user's watchlist

Visual Examples:

Temporarily watch a page via star, before selection made

500px-Watch_a_page_temporarily_with_dropdown,_mockup_example.png (212×500 px, 99 KB)

Temporarily watch a page via star, after selection made
500px-Temporarily_watch_a_page_via_star_with_dropdown,_part_2.png (172×500 px, 77 KB)

Unwatch a page
500px-Removal_from_temporary_watchlist_(mockup_example).png (121×500 px, 46 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ifried renamed this task from Watchlist Expiry: Implement Support for Star Functionality, part 2 to Watchlist Expiry: Add a popup to watch pages temporarily.Mar 25 2020, 6:06 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
Mooeypoo updated the task description. (Show Details)

Split to two tickets:

  1. Implement the loading of the popup, replacing Toast (current behavior) with OOUI
  2. Augment the OOUI popup with the acceptance criteria on the expiry behavior
ifried updated the task description. (Show Details)

This ticket has been subdivided into 2 tasks, which are currently being worked on. I'll close this ticket once those 2 tasks are finished.

ifried renamed this task from Watchlist Expiry: Add a popup to watch pages temporarily to Watchlist Expiry: Add a popup to watch pages temporarily - BEING WORKED ON IN SEPARATE SUBTASKS.Apr 28 2020, 9:07 PM
ifried moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.
ifried claimed this task.

The subtasks for this task have been completed, so I'm marking this work as Resolved.