Page MenuHomePhabricator

Reply link not appearing on some hu.wiki pages
Closed, ResolvedPublic

Description

⚠️I have not been able to reproduce this issue on desktop Chrome Version 80.0.3987.163.


Someone on hu.wiki is reporting [1] the "Reply" links are not visible on a particular person's user talk page. [2]

Expected behavior

  1. Visit: https://hu.wikipedia.org/wiki/Szerkeszt%C5%91vita:Hungarikusz_Firk%C3%A1sz
  2. Notice "Reply" links appear

Reported behavior

  1. Visit: https://hu.wikipedia.org/wiki/Szerkeszt%C5%91vita:Hungarikusz_Firk%C3%A1sz
  2. Notice "Reply" links DO NOT appear

  1. https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Konzult%C3%A1ci%C3%B3_a_vitalapokr%C3%B3l_%C3%A9s_a_k%C3%B6z%C3%B6ss%C3%A9gi_kommunik%C3%A1ci%C3%B3r%C3%B3l&type=revision&diff=22444702&oldid=22433317&diffmode=source
  2. https://hu.wikipedia.org/wiki/Szerkeszt%C5%91vita:Hungarikusz_Firk%C3%A1sz

Event Timeline

@Tgr and I investigated this.

The issue was caused by an on-wiki script that was crashing, and preventing other tools from running. It should be resolved now, by these two edits: https://hu.wikipedia.org/w/index.php?title=MediaWiki:Gadget-jquery-tools-tabs.js&diff=prev&oldid=22452518 https://hu.wikipedia.org/w/index.php?title=MediaWiki:Gadget-wikimenu.js&diff=prev&oldid=22452522

The on-wiki script implements the tabbed navigation near the top of the page ("Tudnivalók a lapról" and "Archívum"). Its implementation was defining a method $.fn.tabs, which is the same name as used by jQuery UI, which is loaded on user talk pages on hu.wp by the WikiLove extension (which provides some standard happy messages you can send to another user from the "heart" icon in page navigation).

Depending on the order in which the two scripts executed, either the tabs would work correctly and WikiLove wouldn't (probably – I haven't tried it before we fixed the bug), or WikiLove would work but the tabs would crash. That's why you couldn't reproduce the bug.

The immediate cause of the issue is rMWb76856675d78: resources: Collapse all jQuery UI modules into one deprecated mega-module (T219604), which causes all of jQuery UI to be loaded on talk pages, instead of only some of the modules (so previously the naming conflict was avoided). We fixed it by simply renaming the method to $.fn.jqttabs.

I can see the reply links now on that page. @ppelberg: could you please confirm this with the original reporter.

I can see the reply links now on that page...

Excellent

@ppelberg: could you please confirm this with the original reporter.

For sure. I've asked them [1] and I will report back what I hear.


  1. https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia%3AKonzult%C3%A1ci%C3%B3_a_vitalapokr%C3%B3l_%C3%A9s_a_k%C3%B6z%C3%B6ss%C3%A9gi_kommunik%C3%A1ci%C3%B3r%C3%B3l&type=revision&diff=22459373&oldid=22445477