Page MenuHomePhabricator

Remove unused jquery.ui.* and jquery.effects.* modules
Open, NormalPublic

Description

In T219403: Remove jquery.ui.spinner removal of deprecated and unused jquery.ui.* modules started, so I think it's a good idea to continue. At least jquery.ui.accordion seems equally unused (https://codesearch.wmflabs.org/search/?q=jquery%5C.ui%5C.accordion&i=nope&files=&repos=, someone should check gadgets).

A similar group of modules is jquery.effects.*, which has only very few uses (https://codesearch.wmflabs.org/search/?q=jquery%5C.effects%5C.&i=nope&files=&repos=), leaving many of these modules completely unused:

  • jquery.effects.bounce
  • jquery.effects.explode
  • jquery.effects.fold
  • jquery.effects.pulsate
  • jquery.effects.slide
  • jquery.effects.transfer
  • jquery.effects.scale
  • jquery.effects.clip
  • jquery.effects.drop
  • jquery.effects.fade

Together, these use over 500 bytes in the registry that could be saved.

Perhaps even more of these modules can be removed, some have just one or two uses which perhaps can easily be replaced, especially for effects.

Event Timeline

Schnark created this task.Mar 29 2019, 10:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2019, 10:04 AM
Volker_E added subscribers: Krinkle, Esanders.

Sounds good to me. For this task and MW 1.33, let's focus only one the ones that have 0 usage in "Codesearch Everywhere".

Change 505282 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Remove unused jquery.ui.* and jquery.effects.* modules

https://gerrit.wikimedia.org/r/505282

D3r1ck01 claimed this task.Apr 19 2019, 6:35 PM
D3r1ck01 added a project: User-D3r1ck01.
D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.

Using the new mwgrep (with JSON and gadgets-definition):

mwgrep "jquery.effects.(bounce|clip|drop|explode|fade|fold|pulsate|scale|slide|transfer)"
commonswiki         MediaWiki:Gadget-EnhancedPOTY.js
commonswiki         MediaWiki:Gadget-catMoveLink.js
commonswiki         MediaWiki:Gadget-progressDialog.js
  • MediaWiki:Gadget-EnhancedPOTY.js has "clip" and "bind"
  • MediaWiki:Gadget-catMoveLink.js has "drop"
  • MediaWiki:Gadget-progressDialog.js has "scale", "fade" and "drop"
Esanders updated the task description. (Show Details)Apr 30 2019, 1:49 PM
D3r1ck01 removed D3r1ck01 as the assignee of this task.May 18 2019, 2:59 PM
D3r1ck01 removed a project: User-D3r1ck01.
D3r1ck01 awarded a token.
D3r1ck01 added a subscriber: D3r1ck01.
Krinkle moved this task from Backlog to Deprecate/Remove on the MW-1.34-release board.
  • MediaWiki:Gadget-EnhancedPOTY.js has "clip" and "bind"
  • MediaWiki:Gadget-catMoveLink.js has "drop"
  • MediaWiki:Gadget-progressDialog.js has "scale", "fade" and "drop"

Thanks for this list @Esanders

D3r1ck01 claimed this task.May 22 2019, 7:30 PM
Restricted Application added a project: User-D3r1ck01. · View Herald TranscriptMay 22 2019, 7:30 PM

Change 505282 merged by jenkins-bot:
[mediawiki/core@master] resources: Remove unused jquery.effects.* modules

https://gerrit.wikimedia.org/r/505282

D3r1ck01 removed D3r1ck01 as the assignee of this task.Jun 20 2019, 11:42 AM
D3r1ck01 updated the task description. (Show Details)
D3r1ck01 removed a project: User-D3r1ck01.

As a next step here, I propose that we make jQuery UI one module, with its alternate partial names aliases for the main module (to deprecate in 1.34), which we can then remove in 1.35 (similar to mediawiki.api.* modules previously), leaving only one module in the registry.

The deprecation for that module would then continue under T49145, which is separate from this.

Krinkle triaged this task as Normal priority.Jul 30 2019, 12:11 AM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.