Page MenuHomePhabricator

Unbreak now (please) : newly broken CentralNotice admin interface
Closed, ResolvedPublic

Description

Hey @AndyRussG, some time in the last hour or so, the CentralNotice admin interface changed and certain elements are now broken.

For example:

^ Only Save is functional for me.

Index of banners:

Details

Related Gerrit Patches:
mediawiki/core : wmf/1.35.0-wmf.10Revert "jquery.ui: Remove "jquery.ui.*" and "jquery.effects.*" aliases"
mediawiki/extensions/CentralNotice : wmf/1.35.0-wmf.10Remove use of jquery.ui module aliases
mediawiki/extensions/CentralNotice : masterRemove use of jquery.ui module aliases
mediawiki/extensions/CentralNotice : wmf_deployRemove use of jquery.ui module aliases

Event Timeline

spatton created this task.Dec 11 2019, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2019, 9:03 PM

I see two related looking javascript errors:

Skipped unresolvable module ext.centralNotice.adminUi.bannerEditor
resolveStubbornly @ load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:9

Error: Unknown module: jquery.ui.datepicker

Timing makes me wonder if it's related to the train deployment that just went out?

Pcoombe triaged this task as Unbreak Now! priority.Dec 11 2019, 9:11 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptDec 11 2019, 9:11 PM

We are discussing on IRC. It's possibly due to the train deploy and #wikimedia-operations has been notified.

jquery.ui.datepicker was removed in wmf.10, yes. wmf_deploy strikes yet again.

jquery.ui.datepicker was removed in wmf.10, yes. wmf_deploy strikes yet again.

aaaarg... 8p thanks for the quick rollback @Jdforrester-WMF!!!

This is now rolled back on production. There's a whole bunch of jquery.ui stuff... See CentralNoticeHooks.php.

As per T219604, it's just the RL modules aliases that have changed, but the modules are still around, so we should be able to fix pretty easily.

Change 556477 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralNotice@master] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556477

Change 556483 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@wmf/1.35.0-wmf.10] Revert "jquery.ui: Remove "jquery.ui.*" and "jquery.effects.*" aliases"

https://gerrit.wikimedia.org/r/556483

Change 556477 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556477

Change 556487 had a related patch set uploaded (by AndyRussG; owner: Jforrester):
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556487

Change 556487 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556487

Change 556497 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.10] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556497

Change 556497 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf/1.35.0-wmf.10] Remove use of jquery.ui module aliases

https://gerrit.wikimedia.org/r/556497

Mentioned in SAL (#wikimedia-operations) [2019-12-11T23:13:13Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.10/extensions/CentralNotice/includes/CentralNoticeHooks.php: T240505 Remove CentralNotice's used of deprecated jquery.ui module aliases (duration: 01m 25s)

Jdforrester-WMF closed this task as Resolved.Dec 11 2019, 11:22 PM
Jdforrester-WMF claimed this task.

Declaring this fix.

Change 556483 abandoned by Jforrester:
Revert "jquery.ui: Remove "jquery.ui.*" and "jquery.effects.*" aliases"

https://gerrit.wikimedia.org/r/556483