Page MenuHomePhabricator

Reduce task notification noise/frequency of changes to associated open patchsets
Open, Needs TriagePublic

Description

In T89940 we replicated open patchsets from Gerrit to Diffusion as a way of keeping feature parity with gitblit.

The downside of this is that for gerrit changes that go through many iterations (which is not uncommon and a good thing) will 'spam' the associated task(s) with the updates.

Workaround:

For the purpose of this functionality, see this exchange on the referenced task:

The one use case I have for refs/changes in phabricator is for converting gerrit unmerged changes into differential diffs.

There's a difference between having the refs on-disk and importing and displaying them though :)

Having them in diffusion makes importing them a lot easier thanks to DifferentialDiffExtractionEngine.php

Event Timeline

greg created this task.Aug 16 2016, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2016, 9:54 PM

The downside of this is that for gerrit changes that go through many iterations (which is not uncommon and a good thing) will 'spam' the associated task(s) with the updates.

Isn't that the same as gerritbot now? what is the frequency difference between the two for example?

greg added a comment.Aug 17 2016, 4:30 PM

Isn't that the same as gerritbot now?

No, Gerritbot only notifies on new associated patch creation (or the adding of the correct Bug: Twhatever line) then either merge or abandonment.

bd808 awarded a token.Aug 28 2016, 3:38 PM

I've done this for perf team repos, and mediawiki/core. But it still happens for lots of other repositories, such as at T224224#5211032 for every iteration of a patch for extension-GrowthExperiments.

Could we turn these off for all Diffusion repos at once with a DB query or bot of some kind?

Mentioned in SAL (#wikimedia-releng) [2019-06-13T15:33:38Z] <Krinkle> Disable "Publish/Notify" for quibble.git in diffusion, T143162, T196347

Mentioned in SAL (#wikimedia-releng) [2019-06-15T00:17:57Z] <Krinkle> Disable "Publish/Notify" for mediawiki/libs/ObjectFactory.git in Diffusion – T222409, T143162

greg moved this task from INBOX to Later / Need volunteer on the Release-Engineering-Team-TODO board.

Do we still have a good use case for these to be mirrored to Diffusion?