Page MenuHomePhabricator
Create Task
Maniphest T250209

[Bug] mobile-html cache not invalidated when associated wikidata item is edited
Closed, ResolvedPublic
Actions

Assigned To
• Pchelolo
Authored By
cooltey
Apr 14 2020, 5:21 PM
Tags
Referenced Files
F31788910: Screenshot at Apr 30 12-03-15.png
Apr 30 2020, 7:04 PM
F31788912: Screenshot at Apr 30 12-03-32.png
Apr 30 2020, 7:04 PM
F31756645: Screenshot at Apr 14 10-18-31.png
Apr 14 2020, 5:21 PM
F31756647: Screenshot at Apr 14 10-18-13.png
Apr 14 2020, 5:21 PM
Subscribers
Aklapper
• bearND
cooltey
JoeWalsh
• Mholloway
• Pchelolo

Description

It appears that mobile-html pages aren't cleared from the cache when the associated Wikidata item is edited. It seems like this task would be resolved if the configuration was similar to the summary endpoint, where edits to the Wikidata item should purge the cache for the associated articles.

Original bug:

Steps to reproduce

  1. Go to Suggested edits (Android app) and find articles that need descriptions
  2. Add descriptions
  3. Check the articles

Expected

See the description on the mobile-html page

Actual

Still shows "Add description" on the page

Screenshot at Apr 14 10-18-31.png (930×1 px, 223 KB)

Screenshot at Apr 14 10-18-13.png (654×1 px, 179 KB)

To confirm that the whether the description is added or not, please check with the wikidata page.

Details

SubjectRepoBranchLines +/-
Rerender mobile-html on wikidata description changesoperations/deployment-chartsmaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

cooltey created this task.Apr 14 2020, 5:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2020, 5:21 PM
JoeWalsh moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Apr 14 2020, 7:51 PM
JoeWalsh edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
JoeWalsh mentioned this in T250269: Unable to add or edit title descriptions.Apr 15 2020, 12:31 PM
JoeWalsh raised the priority of this task from Medium to High.Apr 15 2020, 3:53 PM
JoeWalsh edited projects, added Product-Infrastructure-Team-Backlog-Deprecated, Platform Engineering; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).
JoeWalsh moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.
• Pchelolo claimed this task.Apr 15 2020, 3:56 PM
• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
• Pchelolo moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
JoeWalsh renamed this task from [Bug] Article description does not show on the mobile-html page immediately after adding it to [Bug] mobile-html cache not invalidated when associated wikidata item is edited.Apr 15 2020, 3:57 PM
JoeWalsh removed • Pchelolo as the assignee of this task.
JoeWalsh assigned this task to • Pchelolo.
JoeWalsh updated the task description. (Show Details)
JoeWalsh added a subscriber: • Pchelolo.
• Pchelolo moved this task from Later to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Apr 15 2020, 4:09 PM
• Mholloway subscribed.Apr 15 2020, 5:23 PM
gerritbot added a comment.Apr 28 2020, 9:30 PM

Change 593066 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/deployment-charts@master] Rerender mobile-html on wikidata description changes

https://gerrit.wikimedia.org/r/593066

gerritbot added a project: Patch-For-Review.Apr 28 2020, 9:30 PM
• Pchelolo moved this task from Ready (WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Apr 28 2020, 9:40 PM

The patch above should fix the problem. I was not aware mobile-html had a dependency on Wikidata description.

gerritbot added a comment.Apr 29 2020, 3:37 PM

Change 593066 merged by jenkins-bot:
[operations/deployment-charts@master] Rerender mobile-html on wikidata description changes

https://gerrit.wikimedia.org/r/593066

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2020, 4:10 PM
• Charlotte mentioned this in T249770: Inconsistent caching/staleness of mobile-html responses for certain articles.Apr 30 2020, 3:03 PM
• Mholloway added a comment.Apr 30 2020, 3:13 PM

I believe the fix for this was deployed yesterday. @cooltey would you mind checking now in the app?

cooltey added a comment.Apr 30 2020, 7:04 PM

Hi @Mholloway, I am still seeing the issue in the beta app.

https://en.wikipedia.org/api/rest_v1/page/mobile-html/Holy_Spirit_College

Screenshot at Apr 30 12-03-15.png (472×1 px, 148 KB)

https://www.wikidata.org/wiki/Q5886245
Screenshot at Apr 30 12-03-32.png (374×1 px, 110 KB)

• Pchelolo added a comment.Apr 30 2020, 7:17 PM

The content that was already stored will not be regenerated right away after this change. If you want to regenerate all the content, I guess we'd have to truncate mobile-html table, or do a dump or bump the mobile-html version

cooltey added a comment.May 1 2020, 3:55 PM

Thanks, @Pchelolo

The processes I went through was:
Submitted a description (wikidata) to a page -> visited the mobile-html page for the first time and didn't see the wikidata -> tried to refresh the page and still didn't see the wikidata.

I didn't visit the page before adding the description (wikidata) to the page, and I believe we should see the added/updated description to be shown on the page right away otherwise it will be like a broken function to the users.

• Pchelolo moved this task from Waiting for Review to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.May 1 2020, 4:00 PM

Ok, heh.. the fix wasn't actually deployed it seems. It's been merged, but not yet moved into production. I'll ping you when it is.

cooltey added a comment.May 1 2020, 4:08 PM

I see. Thank you @Pchelolo

• Mholloway added a comment.May 4 2020, 4:55 PM

@Pchelolo My comment above at T250209#6097450 was based on having seen that hnowlan did a changeprop deployment after https://gerrit.wikimedia.org/r/593066 was merged. But I guess you'll need to do a new chart release and deploy that in order for the new config to take effect — is that correct?

• Pchelolo added a comment.May 4 2020, 4:55 PM

But I guess you'll need to do a new chart release and deploy that in order for the new config to take effect — is that correct?

Yeah.

• Mholloway added a comment.May 4 2020, 5:23 PM

Hmm, but wait a minute. It looks like the 0.9.30 release was created after that patch was merged. I guess it just needs to be deployed, then.

JoeWalsh subscribed.May 5 2020, 3:51 PM
In T250209#6105534, @Pchelolo wrote:

But I guess you'll need to do a new chart release and deploy that in order for the new config to take effect — is that correct?

Yeah.

@Pchelolo is there a scheduled or estimated date for when that will happen?

• Pchelolo added a comment.May 5 2020, 4:01 PM

Apologies for the delays. It has happened this morning.

JoeWalsh added a comment.May 5 2020, 4:16 PM
In T250209#6109333, @Pchelolo wrote:

Apologies for the delays. It has happened this morning.

Thanks for the update! It looks like I'm still seeing the same issue. I added a title description to this article with this edit and the page is still outdated. It's properly updated on labs. It looks like the summary hasn't been updated either.

• Pchelolo added a comment.May 5 2020, 4:19 PM
In T250209#6109408, @JoeWalsh wrote:
In T250209#6109333, @Pchelolo wrote:

Apologies for the delays. It has happened this morning.

Thanks for the update! It looks like I'm still seeing the same issue. I added a title description to this article with this edit and the page is still outdated. It's properly updated on labs. It looks like the summary hasn't been updated either.

I'm seeing the description: https://en.wikipedia.org/api/rest_v1/page/mobile-html/HDR10+

JoeWalsh added a comment.May 5 2020, 4:25 PM
In T250209#6109432, @Pchelolo wrote:
In T250209#6109408, @JoeWalsh wrote:
In T250209#6109333, @Pchelolo wrote:

Apologies for the delays. It has happened this morning.

Thanks for the update! It looks like I'm still seeing the same issue. I added a title description to this article with this edit and the page is still outdated. It's properly updated on labs. It looks like the summary hasn't been updated either.

I'm seeing the description: https://en.wikipedia.org/api/rest_v1/page/mobile-html/HDR10+

OK - It looks like that might be the same URL encoding bug as before. I'm seeing the description with https://en.wikipedia.org/api/rest_v1/page/mobile-html/HDR10%2B but not on https://en.wikipedia.org/api/rest_v1/page/mobile-html/HDR10+

• bearND subscribed.May 5 2020, 4:50 PM

Maybe a client side caching issue or it has been updated since. I'm seeing the description with both URLs.

• Pchelolo moved this task from Waiting for deployment to Done on the Platform Team Workboards (Clinic Duty Team) board.May 11 2020, 3:14 PM

We've actually broken purging again, bu fixed now. We are going to finish working on purges soon, so we would stop breaking this.

Naike closed this task as Resolved.May 22 2020, 6:56 AM
• Mholloway mentioned this in T269003: Caching issue for title descriptions in German Wikipedia.Nov 30 2020, 5:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits