Page MenuHomePhabricator

Add warning/explanation to no-JS article and talk page conflicts
Closed, ResolvedPublic1 Estimated Story Points

Description

Description
Because no-JS pages have no pop-up to explain the UI and orient users to the issue, add a warning to top of page. The design for both page types is the same, but the wording is different. Use OOUI MessageWidget (type: 'error').

Article pages: "While you were editing, another user edited the same page and published before you. Please review both versions and merge them. Only the text in the selected boxes will be saved when you click “Publish changes.” "

Talk pages: "Someone else posted at the same time as you. Please review the comments below and choose the order to be published. If needed, you can edit your text."

For both, adjust feedback message to use OOUI MessageWidget (type: 'notice').

Mock ups



Acceptance criteria

  • Users without JS, see warning every time they encounter the edit conflict UI, for both talk and article pages
  • On article pages, the warning should reference whatever text the wiki uses the publishing button using {{savechanges}}
  • Adjust feedback message to use OOUI MessageWidget (type: 'notice') rather than custom warningbox style.

Event Timeline

Lena_WMDE set the point value for this task to 2.Apr 23 2020, 9:36 AM

@ecohen Just to confirm, the feedback message should be adjusted to use OOUI "notice" style for both JS and no-JS, right?

Change 595546 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] [WIP] Adjust feedback box to use OOUI styles

https://gerrit.wikimedia.org/r/595546

A related question: either through oversight or by design, we have no feedback message on the talk page, for either JS or no-JS users. Should I add this?

Change 595555 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Display overview when advanced help not available

https://gerrit.wikimedia.org/r/595555

Change 595559 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] [DNM] Show feedback notice for talk pages

https://gerrit.wikimedia.org/r/595559

@awight Re: changing the feedback message to notice style, yes that's correct. We realized that this is what it should have been anyway, plus it helps differentiate between the types of content for the two messages.

@Lena_WMDE What do you think about adding the feedback message to the talk page? Ideally we would get feedback about this design as well, especially since it hasn't yet been used by anyone. Not sure how much extra work it is do this though.

In T250501#6128222, @ecohen wrote:

@Lena_WMDE What do you think about adding the feedback message to the talk page? Ideally we would get feedback about this design as well, especially since it hasn't yet been used by anyone. Not sure how much extra work it is do this though.

JFYI, the coding work is already done (it was trivial), so take your time deciding on the proper design.

Change 595546 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Adjust feedback box to use OOUI styles

https://gerrit.wikimedia.org/r/595546

awight added a subscriber: awight.

Discussed with @Lena_WMDE, and if the coding work is done then it makes sense to include it.

Just need to make sure that the link to the feedback page on DE wiki is to the DE project page. @max-klemm-WMDE is there a separate place for feedback on the talk pages? Or a section on the talk page we should link to?

Change 595897 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Remove some unused CSS

https://gerrit.wikimedia.org/r/595897

Change 595897 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove some unused CSS

https://gerrit.wikimedia.org/r/595897

Lena_WMDE changed the point value for this task from 2 to 1.May 13 2020, 11:07 AM

Change 595555 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Display overview when advanced help not available

https://gerrit.wikimedia.org/r/595555

In T250501#6128722, @ecohen wrote:

Discussed with @Lena_WMDE, and if the coding work is done then it makes sense to include it.

Just need to make sure that the link to the feedback page on DE wiki is to the DE project page. @max-klemm-WMDE is there a separate place for feedback on the talk pages? Or a section on the talk page we should link to?

Yes, here's the text we present:

Du kannst mithelfen, diese Funktion zu verbessern, wenn du dein Feedback auf diese Seite schreibst.

Change 597012 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Reuse existing SplitConflictUtils::addTargetBlankToLinks()

https://gerrit.wikimedia.org/r/597012

Change 595559 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Show feedback notice for talk pages

https://gerrit.wikimedia.org/r/595559

Change 597012 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Reuse existing SplitConflictUtils::addTargetBlankToLinks()

https://gerrit.wikimedia.org/r/597012

thiemowmde claimed this task.
thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-05-13 board.

Change 607240 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Use same "publishchanges" button label in all messages

https://gerrit.wikimedia.org/r/607240

Change 607240 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Use same "publishchanges" button label in all messages

https://gerrit.wikimedia.org/r/607240