Add lazy loading on Mediawiki powered-by icon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Apr 27 2020, 6:23 PM

Description

From https://github.com/wikimedia/mediawiki/pull/110

From b382b7958272ce89cc0cd168a5701835dd3b0a51 Mon Sep 17 00:00:00 2001
From: Ruben Barkow-Kuder <rubo77@users.noreply.github.com>
Date: Sun, 26 Apr 2020 07:52:45 +0200
Subject: [PATCH] Add lazy loading on Mediawiki powered-by icon

This will not load the icon while it is offscreen, only when a user scrolls down, it is loaded
---
 includes/skins/Skin.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 0b4dc9a..8da2c34 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -910,7 +910,7 @@ abstract class Skin extends ContextSource {
                );
                $text = '<a href="https://www.mediawiki.org/"><img src="' . $url1
                        . '" srcset="' . $url1_5 . ' 1.5x, ' . $url2 . ' 2x" '
-                       . 'height="31" width="88" alt="Powered by MediaWiki" /></a>';
+                       . 'height="31" width="88" alt="Powered by MediaWiki" loading="lazy" /></a>';
                Hooks::run( 'SkinGetPoweredBy', [ &$text, $this ] );
                return $text;
        }
-- 
2.20.1

https://caniuse.com/#search=loading%3D%22lazy%22

Details

	Subject	Repo	Branch	Lines +/-
	Add lazy loading on Mediawiki powered-by icon	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Open	None	T148047 Desktop MediaWiki should be able to lazy load images
Resolved	• Gilles	T239377 Use native <img loading=lazy> for non-printable images
Resolved	Reedy	T251181 Add lazy loading on Mediawiki powered-by icon

Event Timeline

Reedy created this task.Apr 27 2020, 6:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2020, 6:23 PM

Change 592733 had a related patch set uploaded (by Reedy; owner: Ruben Barkow-Kuder):
[mediawiki/core@master] Add lazy loading on Mediawiki powered-by icon

https://gerrit.wikimedia.org/r/592733

gerritbot added a project: Patch-For-Review.Apr 27 2020, 6:24 PM

Jdlrobson added a project: Performance-Team.Apr 28 2020, 3:51 PM

Change 592733 merged by jenkins-bot:
[mediawiki/core@master] Add lazy loading on Mediawiki powered-by icon

https://gerrit.wikimedia.org/r/592733

Reedy closed this task as Resolved.Apr 28 2020, 4:36 PM

Reedy claimed this task.

Reedy mentioned this in T251292: (native) lazy-load icons that aren't part of the printed view.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 28 2020, 5:00 PM

Krinkle added a parent task: T239377: Use native <img loading=lazy> for non-printable images.Apr 28 2020, 6:48 PM

Krinkle mentioned this in T239377: Use native <img loading=lazy> for non-printable images.

Rubo77 subscribed.May 3 2020, 4:31 PM

Looks like it didn't work. Or perhaps stopped working.

In T239377#6165498, @Jdforrester-WMF wrote:

This is […] not working for the MediaWiki one (from Skin.php):


<ul id="footer-icons" class="noprint">
	…
	<li id="footer-poweredbyico"><a href="https://www.mediawiki.org/">
		<img src="/static/images/poweredby_mediawiki_88x31.png" alt="Powered by MediaWiki" srcset="/static/images/poweredby_mediawiki_132x47.png 1.5x, /static/images/poweredby_mediawiki_176x62.png 2x" width="88" height="31"></a>
	</li>
</ul>