Page MenuHomePhabricator
Create Task
Maniphest T251534

Special:UserRights shows "send email" for user without valid email
Open, Needs TriagePublic
Actions

Description

How to reproduce

  1. Find user without valid email / with disabled email
  2. go to [[Special:UserRights/username]]
  3. there is a link "send email"
  4. after clicking on the link, there is no form for sending email, but to elect a username
  5. after electing and confirming username, the form shows "This user has not specified a valid email address."

Expected behaviour
If the user hasn't valid email / have disabled email, on [[Special:UserRights/username]] is no link to send email.

Details

SubjectRepoBranchLines +/-
Revert "Don't show email link if the user cannot be emailed. (2)"mediawiki/coremaster+2 -6
Don't show email link if the user cannot be emailed. (2)mediawiki/coremaster+6 -2
Revert "Don't show email link if the user cannot be emailed."mediawiki/coremaster+2 -2
Revert "Don't show email link if the user cannot be emailed."mediawiki/corewmf/1.35.0-wmf.35+2 -2
Don't show email link if the user cannot be emailed.mediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

KuboF created this task.Apr 30 2020, 3:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2020, 3:03 PM
RhinosF1 added a project: MediaWiki-User-management.Apr 30 2020, 3:04 PM
gerritbot added a comment.May 1 2020, 6:01 AM

Change 593666 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Don't show email link if the user cannot be emailed.

https://gerrit.wikimedia.org/r/593666

gerritbot added a project: Patch-For-Review.May 1 2020, 6:01 AM
gerritbot added a comment.Jun 1 2020, 7:10 PM

Change 593666 merged by jenkins-bot:
[mediawiki/core@master] Don't show email link if the user cannot be emailed.

https://gerrit.wikimedia.org/r/593666

matmarex closed this task as Resolved.Jun 1 2020, 7:12 PM
matmarex assigned this task to Ammarpad.
matmarex subscribed.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).Jun 1 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 1 2020, 8:10 PM
DannyS712 mentioned this in T254417: SpecialUserrights.php: Call to undefined method CentralAuthGroupMembershipProxy::canReceiveEmail().Jun 4 2020, 12:00 AM
gerritbot added a comment.Jun 4 2020, 12:02 AM

Change 602196 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602196

gerritbot added a project: Patch-For-Review.Jun 4 2020, 12:02 AM
DannyS712 reopened this task as Open.Jun 4 2020, 12:04 AM
DannyS712 subscribed.

Just +2'ed the revert - UserrightsPage::showEditUserGroupsForm accepts either a User or a UserRightsProxy object, and UserRightsProxy lacks the canReceiveEmail method the patch tried to call

gerritbot added a comment.Jun 4 2020, 12:08 AM

Change 602198 had a related patch set uploaded (by Reedy; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.35] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602198

gerritbot added a comment.Jun 4 2020, 12:21 AM

Change 602196 merged by jenkins-bot:
[mediawiki/core@master] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602196

gerritbot added a comment.Jun 4 2020, 12:26 AM

Change 602198 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.35] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602198

DannyS712 removed a project: Patch-For-Review.Jun 4 2020, 12:33 AM
Stashbot added a comment.Jun 4 2020, 12:36 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-04T00:36:01Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.35/includes/specials/SpecialUserrights.php: T254417 T251534 (duration: 01m 06s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).Jun 4 2020, 1:00 AM
• Onkoydenkovuldum edited projects, added Articles Needing links; removed MediaWiki-User-management.Jun 4 2020, 11:36 PM
Reedy edited projects, added MediaWiki-User-management; removed Articles Needing links.Jun 4 2020, 11:54 PM
JJMC89 moved this task from Backlog to User rights on the MediaWiki-User-management board.Jun 6 2020, 5:09 AM
gerritbot added a comment.Jun 28 2020, 11:55 AM

Change 608213 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Don't show email link if the user cannot be emailed. (2)

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608213

gerritbot added a project: Patch-For-Review.Jun 28 2020, 11:55 AM
gerritbot added a comment.Jun 28 2020, 1:14 PM

Change 608213 merged by jenkins-bot:
[mediawiki/core@master] Don't show email link if the user cannot be emailed. (2)

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608213

DannyS712 added a comment.Jun 28 2020, 1:34 PM
In T251534#6262471, @gerritbot wrote:

Change 608213 merged by jenkins-bot:
[mediawiki/core@master] Don't show email link if the user cannot be emailed. (2)

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608213

The new check is to only add the link if $isUserInstance && $user->canReceiveEmail() - this means that Special:GlobalUserRights will never include the link, and Special:UserRights will only include it if the user can receive email. Instead, if we on Special:GlobalUserRights we can't determine if the user can receive email, we should still show the link. Sorry to do this again, but reverting the latest patch. @Ammarpad fyi. Sorry I didn't catch this in review

gerritbot added a comment.Jun 28 2020, 1:35 PM

Change 608228 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "Don't show email link if the user cannot be emailed. (2)"

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608228

gerritbot added a comment.Jun 28 2020, 1:56 PM

Change 608228 merged by jenkins-bot:
[mediawiki/core@master] Revert "Don't show email link if the user cannot be emailed. (2)"

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608228

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 28 2020, 2:00 PM
Ammarpad added a comment.Jun 28 2020, 2:12 PM
In T251534#6262499, @DannyS712 wrote:

The new check is to only add the link if $isUserInstance && $user->canReceiveEmail() - this means that Special:GlobalUserRights will never include the link, and Special:UserRights will only include it if the user can receive email. Instead, if we on Special:GlobalUserRights we can't determine if the user can receive email, we should still show the link. Sorry to do this again, but reverting the latest patch. @Ammarpad fyi. Sorry I didn't catch this in review

No problem

Ammarpad removed Ammarpad as the assignee of this task.Jun 28 2020, 2:13 PM
Ammarpad subscribed.
Pppery removed a project: Patch-For-Review.Mar 29 2023, 12:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL