Maniphest T251805

Contributor gets own contribution count
Closed, ResolvedPublic
Actions

Description

"As a Contributor, I want to get a count of my own contributions, to know how much work I've done for the project."

GET /user/{name}/contributions/count
GET /me/contributions/count

Count of contributions by a given user with username name.

The synonym /me/contributions/count can be used to get the count of the current logged-in user's contributions.

{name} is the user name.

Request body: none

Notable request headers: none

Status:
200 - OK
401 - not authenticated; only used for the /me synonym
404 – no such user

Notable response headers: none

Body: JSON, an object with the following fields:
count: total number of contributions by the user

Details

	Subject	Repo	Branch	Lines +/-
	REST me/contributions/count endpoint	mediawiki/core	master	+287 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T229661 Core REST API in MediaWiki
Declined	None	T247876 User contributions API
Resolved	• nnikkhoui	T251805 Contributor gets own contribution count

Event Timeline

• eprodromou created this task.May 4 2020, 6:23 PM

• eprodromou mentioned this in T251806: Contributor gets count of tagged contributions.

• eprodromou edited projects, added Platform Team Workboards (Green); removed Platform Team Workboards (User Stories).May 11 2020, 3:31 PM

• eprodromou moved this task from Backlog to Next Sprint on the Platform Team Workboards (Green) board.May 11 2020, 5:57 PM

• eprodromou moved this task from Next Sprint to Ready on the Platform Team Workboards (Green) board.May 28 2020, 4:55 PM

Change 605891 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] REST me/contributions/count endpoint

https://gerrit.wikimedia.org/r/605891

gerritbot added a project: Patch-For-Review.Jun 16 2020, 12:25 PM

Counting revisions created by a user is simple enough, but as we discovered during our work on T200259, not all contributions are revisions, some or other things defined by extensions (e.g. discussion contributions from the Flow extension). That complicates things a lot. We would have to live with an inconsistency between the number of contributions listed by /me/contributions, and the number returned by /me/contributions/count for now. We can then introduce a new hook that allows extensions to add to that number to make things consistent again.

WDoranWMF moved this task from Ready to Waiting for Review on the Platform Team Workboards (Green) board.Jul 1 2020, 6:58 PM

Change 605891 merged by jenkins-bot:
[mediawiki/core@master] REST me/contributions/count endpoint

https://gerrit.wikimedia.org/r/605891

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 6 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2020, 10:10 AM

daniel moved this task from Waiting for Review to User Story Review on the Platform Team Workboards (Green) board.Jul 6 2020, 2:17 PM

• eprodromou moved this task from User Story Review to Documentation on the Platform Team Workboards (Green) board.Jul 21 2020, 2:24 PM

Does this ticket represent both /me/contributions/count and /user/{name}/contributions/count? The later doesn't seem to be supported currently.

wow ok your due diligence has uncovered that yes I think we just forgot to implement that one....theres no route for it and the user in UserContributionsCount defaults to "me". @daniel I can work on that one now. It shouldn't take too long.

In T251805#6327750, @nnikkhoui wrote:

wow ok your due diligence has uncovered that yes I think we just forgot to implement that one....theres no route for it and the user in UserContributionsCount defaults to "me". @daniel I can work on that one now. It shouldn't take too long.

Ha - i ignored the second route in the task description, because the title says "Contributor gets *own* contribution count".

Implementing this is easy enough, writing the tests takes some time.

apaskulin moved this task from Documentation to Doing on the Platform Team Workboards (Green) board.Jul 22 2020, 8:16 PM

• eprodromou assigned this task to • nnikkhoui.Jul 29 2020, 3:06 PM

• nnikkhoui moved this task from Doing to User Story Review on the Platform Team Workboards (Green) board.Jul 29 2020, 3:14 PM

WDoranWMF added a project: Platform Team Sprints Board (Sprint 0).Jul 31 2020, 12:21 PM

LGTM

Naike edited projects, added Platform Team Sprints Board (Sprint 1); removed Platform Team Sprints Board (Sprint 0).Aug 7 2020, 10:20 AM

@nnikkhoui, here's the draft of the docs for the contribution endpoints for your review! Feel free to make edits directly to the page, leave comments on the talk page, or leave your feedback here on the task; whatever works best for you :) The examples currently show the beta wiki but will be changed to a non-beta wiki when published to the main docs.