[Spike] SkinTemplateOutputPageBeforeExec is being deprecated. Identify usages and create tasks for fixing
Closed, ResolvedPublicSpike
Actions

Description

As part of the desktop refresh project, Vector will soon no longer run the SkinTemplateOutputPageBeforeExec hook as part of its move away from BaseTemplate in T251212. This will require updates in various extensions. I will open specific bugs in specific projects as I get to them and will likely post the required Gerrit patches so help with code review would be appreciated. I will close this task once the appropriate tasks have been filed

The migration will be done slowly to allow impacted projects to update to preferred hooks and add any ones that are missing.

Results of spike

Impacted extensions that are not compatible with latest MediaWiki

NOTE: These extensions are not compatible with latest MediaWiki so will not be patched.

News

To modify feeds it should use OutputPage::addFeedLink instead in any of the OutputPage hooks.

News (modifies feeds https://gerrit.wikimedia.org/g/mediawiki/extensions/News/+/18480933ba03da21b4596fa006830b801a244a64/News.php#112)

LanguageSelector

LanguageSelector modifies side bar (https://gerrit.wikimedia.org/g/mediawiki/extensions/LanguageSelector/+/8e3c6d6c8a17170b103f7de2f1ee4b5f2b2be111/LanguageSelector.php#299) however the extension is not compatible with the latest mediawiki

Please use SidebarBeforeOutput to add items to the side bar.

PushToWatch

Updates footer
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PushToWatch/+/master/PushToWatch.class.php

Permitted hooks: SkinTemplateGetLanguageLink (Modify language items) BaseTemplateAfterPortlet for adding link after languages. To omit languages altogether from a page, use SidebarBeforeOutput and set languages to false.

SharedHelpPages

Use OutputPage::setCopyright inside an OutputPage hook to modify copyright.

SharedHelpPages (modifies copyright) https://gerrit.wikimedia.org/g/mediawiki/extensions/SharedHelpPages/+/cc4801a5fbc2a7f4476e108ba19a584bd0eabf83/SharedHelpPages.hooks.php#236

Acceptance criteria

WikimediaMessages has been patched and merged Fix
WhoIsWatching https://gerrit.wikimedia.org/g/mediawiki/extensions/WhoIsWatching/+/7e4ac0dee460de88aaeebd0da078820ee7929d44/src/Hook.php#42
SemanticMediaWiki https://github.com/SemanticMediaWiki/SemanticBreadcrumbLinks/issues/69
A task/patch for Wikidata.org has been filed (T253174)
Identify action plan for UniversalLanguageSelector Bug: T253178
Identify action plan for Wikibase (T252841)
A patch exists for BlogPage https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/BlogPage/+/597385

Sign off steps

Update T60137

Details

Subject	Repo	Branch	Lines +/-
WIP: SkinTemplateOutputPageBeforeExecHandler is deprecated	mediawiki/extensions/Wikibase	master	+80 -333
Use of SkinTemplateOutputPageBeforeExec for footer modification is deprecated	mediawiki/extensions/WhoIsWatching	master	+9 -9
SkinTemplate: Set footer keys on template for full compatibility	mediawiki/core	master	+5 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T140664 Achieve predictable MediaWiki routing and cacheable skin data
Resolved		Jdlrobson	T253813 [EPIC] Deprecate the SkinTemplate hooks and simplify the skin<->extension contract.
Resolved		None	T60137 Deprecate the SkinTemplateOutputPageBeforeExec hook
Resolved	Spike	Jdlrobson	T252725 [Spike] SkinTemplateOutputPageBeforeExec is being deprecated. Identify usages and create tasks for fixing
Resolved		Ammarpad	T252841 Update the method Wikibase uses to inject edit language links into the language portlet

Event Timeline

Jdlrobson created this task.May 13 2020, 10:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2020, 10:53 PM

Jdlrobson updated the task description. (Show Details)May 13 2020, 10:54 PM

Jdlrobson updated the task description. (Show Details)May 13 2020, 11:33 PM

Jdlrobson mentioned this in T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.May 13 2020, 11:39 PM

Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.May 14 2020, 4:44 AM

Change 596329 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WhoIsWatching@master] Use of SkinTemplateOutputPageBeforeExec for footer modification is deprecated

https://gerrit.wikimedia.org/r/596329

Change 596330 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Set footer keys on template for full compatibility

https://gerrit.wikimedia.org/r/596330

Jdlrobson added projects: Vector (legacy skin), Desktop Improvements (Vector 2022).May 14 2020, 4:47 AM

Change 596330 merged by jenkins-bot:
[mediawiki/core@master] SkinTemplate: Set footer keys on template for full compatibility

https://gerrit.wikimedia.org/r/596330

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 14 2020, 7:00 AM

Nikerabbit subscribed.May 14 2020, 8:51 AM

Jdlrobson updated the task description. (Show Details)May 14 2020, 3:01 PM

Jdlrobson updated the task description. (Show Details)May 14 2020, 4:52 PM

Jdlrobson renamed this task from SkinTemplateOutputPageBeforeExec being removed from Vector to SkinTemplateOutputPageBeforeExec is being deprecated. Update usages to more appropriate hooks..May 14 2020, 4:57 PM

Jdlrobson moved this task from Next up to Doing on the User-Jdlrobson board.

Jdlrobson mentioned this in T251817: [Dev] Allow extensions to update the footer without resorting to SkinTemplateOutputPageBeforeExec hook.

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)May 14 2020, 5:02 PM

Jdlrobson claimed this task.May 14 2020, 8:38 PM

Jdlrobson added a parent task: T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2019-20-Q4).

Change 596518 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Wikibase@master] Drop "display language portal" hack

https://gerrit.wikimedia.org/r/596518

Nikerabbit updated the task description. (Show Details)May 15 2020, 2:56 PM

Jdlrobson moved this task from Needs triage to Technical on the Vector (legacy skin) board.May 15 2020, 4:57 PM

Jdlrobson renamed this task from SkinTemplateOutputPageBeforeExec is being deprecated. Update usages to more appropriate hooks. to [Spike] SkinTemplateOutputPageBeforeExec is being deprecated. Identify usages and create tasks for fixing.May 19 2020, 7:09 PM

Jdlrobson added a project: Spike.

Jdlrobson updated the task description. (Show Details)

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptMay 19 2020, 7:09 PM

Jdlrobson updated the task description. (Show Details)May 19 2020, 11:38 PM

Jdlrobson closed this task as Resolved.May 20 2020, 12:34 AM

Jdlrobson updated the task description. (Show Details)

Change 596329 merged by jenkins-bot:
[mediawiki/extensions/WhoIsWatching@master] Use of SkinTemplateOutputPageBeforeExec for footer modification is deprecated

https://gerrit.wikimedia.org/r/596329

Change 596518 abandoned by Jdlrobson:
WIP: SkinTemplateOutputPageBeforeExecHandler is deprecated

Reason:
I can't get wikibase setup locally right now, but just to note - I do need to get a fix for this in for the July release branch cut!

https://gerrit.wikimedia.org/r/596518

Ammarpad changed the status of subtask T252841: Update the method Wikibase uses to inject edit language links into the language portlet from Open to Stalled.Jun 6 2020, 5:57 AM

Jdlrobson changed the status of subtask T252841: Update the method Wikibase uses to inject edit language links into the language portlet from Stalled to Open.Jun 6 2020, 6:41 PM

Jdlrobson closed subtask T252841: Update the method Wikibase uses to inject edit language links into the language portlet as Resolved.Jun 11 2020, 9:22 PM