Page MenuHomePhabricator
Create Task
Maniphest T253178

UniversalLanguageSelector should stop using the SkinTemplateOutputPageBeforeExec hook
Closed, ResolvedPublic
Actions

Description

The SkinTemplateOutputPageBeforeExec hook is being deprecated as part of desktop refresh to simplify skin integration points which will make it much easier for skins to be built.

For similar reasons given in T252841 and discussions with Timo in this Gerrit patch the SkinTemplateOutputPageBeforeExec hook should not be used to force the display of the language portal. That is a decision that should rest with the skin.

Vector will currently display the portal provided either the language overlay is full or the BaseTemplateAfterPortlet hook is used to inject content at the end of the language portal.

Monobook, CologneBlue, Modern will not, however they can be patched to do so (also feel free to jump in with your own thoughts in discussions with Timo in this Gerrit patch about whether this decision should rest in core)

Regardless of that decision UniversalLanguageSelector should replace SkinTemplateOutputPageBeforeExec with the new SkinAfterPortlet - I have provided two possible options to show how that might be done. Let me know what you think.

I'm targeting the 1.35 release for deprecating this hook. Let me know if you see any problems with that! Thanks in advance!

Details

SubjectRepoBranchLines +/-
Output uls-settings-trigger in HTML markupmediawiki/extensions/UniversalLanguageSelectormaster+28 -20
SkinTemplateOutputPageBeforeExec is deprecatedmediawiki/extensions/UniversalLanguageSelectormaster+42 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 20 2020, 12:31 AM
gerritbot added a comment.May 20 2020, 12:32 AM

Change 597400 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] SkinTemplateOutputPageBeforeExec is deprecated

https://gerrit.wikimedia.org/r/597400

gerritbot added a project: Patch-For-Review.May 20 2020, 12:32 AM

Change 597401 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] Output uls-settings-trigger in HTML markup

https://gerrit.wikimedia.org/r/597401

Jdlrobson mentioned this in T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.May 20 2020, 12:34 AM
Jdlrobson mentioned this in T252725: [Spike] SkinTemplateOutputPageBeforeExec is being deprecated. Identify usages and create tasks for fixing.
Reedy subscribed.May 20 2020, 1:24 AM

Note, ULS is part of MLEB - https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle (so master of the extension needs to keep support with odler versions of MW)

rMW53ab861a2fcb: Add BaseTemplateAfterPortlet hook to add html after portlets added the "BaseTemplateAfterPortlet" hook, just so other people don't need to chase it down; it's been in MW core since 1.23

Jdlrobson updated the task description. (Show Details)Jun 9 2020, 9:07 PM
Jdlrobson triaged this task as High priority.Jun 9 2020, 9:40 PM
Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.
Jdlrobson moved this task from Backlog to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.
Jdlrobson moved this task from Inbox to OKR Backlog on the User-Jdlrobson board.Jun 9 2020, 11:33 PM
Jdlrobson claimed this task.Jun 9 2020, 11:43 PM
Jdlrobson moved this task from OKR Backlog to Blocked on the User-Jdlrobson board.
santhosh added a project: Language-Team (Language-2020-Focus-Sprint).Jun 12 2020, 6:02 AM
santhosh moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.Jun 12 2020, 6:37 AM
DanielFriesen unsubscribed.Jun 12 2020, 7:36 AM
gerritbot added a comment.Jun 13 2020, 3:27 AM

Change 597400 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] SkinTemplateOutputPageBeforeExec is deprecated

https://gerrit.wikimedia.org/r/597400

Jdlrobson closed this task as Resolved.Jun 13 2020, 3:45 AM
Jdlrobson added a subscriber: santhosh.

Thank you @santhosh !

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 13 2020, 4:00 AM
gerritbot added a comment.Jun 26 2020, 10:46 PM

Change 597401 abandoned by Jdlrobson:
Output uls-settings-trigger in HTML markup

Reason:
Note this was meant more as a proof of concept for the language team of what's possible rather than expecting to be reviewed.

My main objective was https://gerrit.wikimedia.org/r/597400 and that's been resolved. This was a slightly different approach to solving this problem.

I'm abandoning this for now, but wanted to note its likely the web team will need to revisit this, as they move the language cog to the top right of Vector in future work.

https://gerrit.wikimedia.org/r/597401

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2020, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits