Page MenuHomePhabricator

Hard deprecate manually constructing MovePage objects
Open, Needs TriagePublic

Description

MovePageFactory is used for dependency injection, but manually constructing a MovePage object is still not hard deprecated (soft deprecated in 1.34 when MovePageFactory was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507551/ )

Manual construction of MovePage objects in deployed code to update:

  • Core
  • Flow
  • Translate
  • CentralAuth
  • Cognate
  • PageTriage
  • Renameuser
  • Wikibase

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 596795 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Renameuser@master] SpecialRenameuser: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596795

Change 596796 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] ApiPageTriageListTest: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596796

Change 596796 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] ApiPageTriageListTest: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596796

DannyS712 updated the task description. (Show Details)May 22 2020, 9:12 PM

Change 596795 merged by jenkins-bot:
[mediawiki/extensions/Renameuser@master] SpecialRenameuser: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596795

DannyS712 removed DannyS712 as the assignee of this task.Aug 19 2020, 5:55 AM

Unlicking

Change 634825 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Use MovePageFactory in uppercaseTitlesForUnicodeTransition.php

https://gerrit.wikimedia.org/r/634825

Change 634825 merged by jenkins-bot:
[mediawiki/core@master] Use MovePageFactory in uppercaseTitlesForUnicodeTransition.php

https://gerrit.wikimedia.org/r/634825