Page MenuHomePhabricator
Create Task
Maniphest T252934

Hard deprecate manually constructing MovePage objects
Closed, ResolvedPublic
Actions

Assigned To
tchin
Authored By
DannyS712
May 16 2020, 2:17 AM
Tags
Referenced Files
None
Subscribers
Aklapper
DannyS712
• Pchelolo
taavi

Description

MovePageFactory is used for dependency injection, but manually constructing a MovePage object is still not hard deprecated (soft deprecated in 1.34 when MovePageFactory was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507551/ )

Manual construction of MovePage objects in deployed code to update (search):

Details

SubjectRepoBranchLines +/-
Use MovePageFactory and hard deprecate constructing MovePage objects directlymediawiki/coremaster+34 -9
Use MovePageFactorymediawiki/extensions/AbuseFiltermaster+4 -10
Use MovePageFactorymediawiki/extensions/Translatemaster+14 -4
Use MovePageFactory in unit testmediawiki/extensions/Cognatemaster+1 -2
Inject and use MovePageFactory in ApiMovemediawiki/coremaster+20 -5
Use MovePageFactorymediawiki/extensions/Flowmaster+11 -3
Use MovePageFactory in LocalPageMoveJobmediawiki/extensions/CentralAuthmaster+3 -1
Use MovePageFactory in uppercaseTitlesForUnicodeTransition.phpmediawiki/coremaster+6 -5
SpecialRenameuser: Use MovePageFactory to construct MovePagemediawiki/extensions/Renameusermaster+3 -2
ApiPageTriageListTest: Use MovePageFactory to construct MovePagemediawiki/extensions/PageTriagemaster+10 -4
Customize query in gerrit

Event Timeline

DannyS712 created this task.May 16 2020, 2:17 AM
Restricted Application added projects: Growth-Team, Wikidata, User-DannyS712. · View Herald TranscriptMay 16 2020, 2:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.May 16 2020, 2:18 AM

Change 596795 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Renameuser@master] SpecialRenameuser: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596795

gerritbot added a project: Patch-For-Review.May 16 2020, 2:18 AM
gerritbot added a comment.May 16 2020, 2:21 AM

Change 596796 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] ApiPageTriageListTest: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596796

DannyS712 moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.May 16 2020, 2:22 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 added a project: Platform Team Workboards (External Code Reviews).May 17 2020, 10:34 PM
gerritbot added a comment.May 22 2020, 8:53 PM

Change 596796 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] ApiPageTriageListTest: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596796

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 22 2020, 9:00 PM
DannyS712 updated the task description. (Show Details)May 22 2020, 9:12 PM
• Pchelolo moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Jun 25 2020, 2:30 PM
gerritbot added a comment.Jun 25 2020, 2:38 PM

Change 596795 merged by jenkins-bot:
[mediawiki/extensions/Renameuser@master] SpecialRenameuser: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596795

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).Jun 25 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 25 2020, 3:11 PM
DannyS712 removed DannyS712 as the assignee of this task.Aug 19 2020, 5:55 AM

Unlicking

gerritbot added a comment.Oct 18 2020, 7:33 PM

Change 634825 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Use MovePageFactory in uppercaseTitlesForUnicodeTransition.php

https://gerrit.wikimedia.org/r/634825

gerritbot added a project: Patch-For-Review.Oct 18 2020, 7:33 PM
gerritbot added a comment.Oct 21 2020, 8:05 PM

Change 634825 merged by jenkins-bot:
[mediawiki/core@master] Use MovePageFactory in uppercaseTitlesForUnicodeTransition.php

https://gerrit.wikimedia.org/r/634825

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 21 2020, 9:00 PM
gerritbot added a comment.Dec 26 2020, 6:01 PM

Change 651964 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] Use MovePageFactory in LocalPageMoveJob

https://gerrit.wikimedia.org/r/651964

taavi subscribed.Dec 26 2020, 6:02 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 26 2020, 7:19 PM
gerritbot added a comment.Dec 26 2020, 7:21 PM

Change 651964 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Use MovePageFactory in LocalPageMoveJob

https://gerrit.wikimedia.org/r/651964

taavi updated the task description. (Show Details)Dec 26 2020, 7:25 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Dec 26 2020, 8:00 PM
taavi moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.Dec 28 2020, 11:10 AM
gerritbot added a comment.Dec 29 2020, 11:59 AM

Change 652398 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Flow@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/652398

gerritbot added a comment.Dec 30 2020, 1:33 AM

Change 652398 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/652398

taavi updated the task description. (Show Details)Dec 30 2020, 8:37 AM
gerritbot added a comment.Dec 30 2020, 8:55 AM

Change 652488 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Inject and use MovePageFactory in ApiMove

https://gerrit.wikimedia.org/r/652488

taavi moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (External Code Reviews) board.Dec 30 2020, 8:58 AM

Moving back to code review needed for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/652488/ in core.

gerritbot added a comment.Dec 31 2020, 11:15 PM

Change 652488 merged by jenkins-bot:
[mediawiki/core@master] Inject and use MovePageFactory in ApiMove

https://gerrit.wikimedia.org/r/652488

• Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Jan 5 2021, 7:08 PM
gerritbot added a comment.Jan 12 2021, 6:45 AM

Change 655549 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Cognate@master] Use MovePageFactory in unit test

https://gerrit.wikimedia.org/r/655549

gerritbot added a comment.Jan 12 2021, 7:48 AM

Change 655549 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Use MovePageFactory in unit test

https://gerrit.wikimedia.org/r/655549

taavi updated the task description. (Show Details)Jan 12 2021, 7:49 AM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 12 2021, 8:00 AM
gerritbot added a comment.Jan 16 2021, 7:05 PM

Change 656582 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Translate@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/656582

gerritbot added a comment.Jan 16 2021, 7:42 PM

Change 656582 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/656582

taavi updated the task description. (Show Details)Jan 16 2021, 7:43 PM
• Pchelolo claimed this task.Mar 15 2021, 5:40 PM
• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Platform Team Workboards (External Code Reviews).
• Pchelolo updated the task description. (Show Details)
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 24 2021, 11:21 AM
daniel moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.Jun 8 2021, 11:42 AM
• Pchelolo moved this task from PageStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Jul 13 2021, 3:22 PM
• Pchelolo moved this task from Waiting for Review to PageStore pile on the Platform Team Workboards (MW Expedition) board.Jul 13 2021, 7:01 PM
• Pchelolo reassigned this task from • Pchelolo to tchin.Jul 29 2021, 6:11 PM
• Pchelolo subscribed.
gerritbot added a comment.Aug 4 2021, 8:01 PM

Change 710106 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] Use MovePageFactory and hard deprecate constructing MovePage objects directly

https://gerrit.wikimedia.org/r/710106

gerritbot added a project: Patch-For-Review.Aug 4 2021, 8:01 PM
tchin moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Aug 5 2021, 4:07 PM
gerritbot added a comment.Aug 10 2021, 8:08 PM

Change 711195 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/AbuseFilter@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/711195

gerritbot added a comment.Aug 11 2021, 7:26 PM

Change 711195 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/711195

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 11 2021, 8:00 PM
tchin moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Aug 11 2021, 8:25 PM
gerritbot added a comment.Aug 11 2021, 8:29 PM

Change 710106 merged by jenkins-bot:

[mediawiki/core@master] Use MovePageFactory and hard deprecate constructing MovePage objects directly

https://gerrit.wikimedia.org/r/710106

tchin closed this task as Resolved.Aug 18 2021, 1:11 PM
tchin updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL