Page MenuHomePhabricator

Hard deprecate manually constructing MovePage objects
Open, Needs TriagePublic

Description

MovePageFactory is used for dependency injection, but manually constructing a MovePage object is still not hard deprecated (soft deprecated in 1.34 when MovePageFactory was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507551/ )

Manual construction of MovePage objects in deployed code to update (search):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 596795 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Renameuser@master] SpecialRenameuser: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596795

Change 596796 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] ApiPageTriageListTest: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596796

Change 596796 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] ApiPageTriageListTest: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596796

Change 596795 merged by jenkins-bot:
[mediawiki/extensions/Renameuser@master] SpecialRenameuser: Use MovePageFactory to construct MovePage

https://gerrit.wikimedia.org/r/596795

Change 634825 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Use MovePageFactory in uppercaseTitlesForUnicodeTransition.php

https://gerrit.wikimedia.org/r/634825

Change 634825 merged by jenkins-bot:
[mediawiki/core@master] Use MovePageFactory in uppercaseTitlesForUnicodeTransition.php

https://gerrit.wikimedia.org/r/634825

Change 651964 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] Use MovePageFactory in LocalPageMoveJob

https://gerrit.wikimedia.org/r/651964

Change 651964 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Use MovePageFactory in LocalPageMoveJob

https://gerrit.wikimedia.org/r/651964

Change 652398 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Flow@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/652398

Change 652398 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/652398

Change 652488 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Inject and use MovePageFactory in ApiMove

https://gerrit.wikimedia.org/r/652488

Change 652488 merged by jenkins-bot:
[mediawiki/core@master] Inject and use MovePageFactory in ApiMove

https://gerrit.wikimedia.org/r/652488

Change 655549 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Cognate@master] Use MovePageFactory in unit test

https://gerrit.wikimedia.org/r/655549

Change 655549 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Use MovePageFactory in unit test

https://gerrit.wikimedia.org/r/655549

Change 656582 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Translate@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/656582

Change 656582 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use MovePageFactory

https://gerrit.wikimedia.org/r/656582