Page MenuHomePhabricator
Create Task
Maniphest T253636

Use mediawiki-codesniffer 31.0.0 in WikibaseDatamodel when released
Closed, ResolvedPublic
Actions

Description

This is currently unreleased, but will include a fix for T253633: LowerCamelFunctionsNameSniff should allow __serialize and __unserialize magic methods for PHP 7.4 which will allow us to remove some disable comments that were added in https://github.com/wmde/WikibaseDataModel/pull/824

This task has been created to track that fact.

Related Objects
Search...

Event Timeline

Addshore created this task.May 26 2020, 2:16 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 26 2020, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore changed the task status from Open to Stalled.May 26 2020, 2:16 PM
Addshore triaged this task as Low priority.

Stalled on waiting for the release (I believe I am using stalled correctly this time)

Addshore mentioned this in T253624: Evaluate the future of wikibase-codesniffer.May 26 2020, 2:20 PM
Addshore added a project: Code-Health.Jun 9 2020, 8:57 AM
Addshore added a parent task: T260064: Use mediawiki-codesniffer 31.0.0 in Wikibase repositories (that use codesniffer).Aug 10 2020, 3:12 PM
Addshore mentioned this in T260064: Use mediawiki-codesniffer 31.0.0 in Wikibase repositories (that use codesniffer).Aug 10 2020, 3:32 PM
Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Oct 6 2020, 2:34 PM
Lucas_Werkmeister_WMDE subscribed.

Unstalling since a Wikibase CodeSniffer 1.2.0, pulling in MediaWiki CodeSniffer 31.0.0, is now available.

Lucas_Werkmeister_WMDE claimed this task.Oct 16 2020, 11:25 AM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lucas_Werkmeister_WMDE added a comment.Oct 16 2020, 1:30 PM

https://github.com/wmde/WikibaseDataModel/pull/829

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 16 2020, 1:30 PM
Rosalie_WMDE closed this task as Resolved.Oct 16 2020, 1:56 PM
Rosalie_WMDE reopened this task as Open.
Michael moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 16 2020, 3:09 PM
Michael subscribed.

The task description talks about removing some disable comments. As far as I can tell, that hasn't happened yet.

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 16 2020, 4:20 PM

https://github.com/wmde/WikibaseDataModel/pull/830

Michael closed this task as Resolved.Oct 16 2020, 4:45 PM
Michael moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
In T253636#6550500, @Lucas_Werkmeister_WMDE wrote:

https://github.com/wmde/WikibaseDataModel/pull/830

Merged. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits