Page MenuHomePhabricator

UrlShortener should use the SidebarBeforeOutput hook
Closed, ResolvedPublic

Description

The UrlShortener extension currently uses the BaseTemplateToolbox hook to add a link to the sidebar.

The SIdebarBeforeOutput hook now includes the toolbox and languages links so can be used to add to this array and should use that hook instead, per the deprecation plan of BaseTemplateToolbox (T253416)

Event Timeline

Ammarpad claimed this task.May 27 2020, 6:09 AM

Change 598958 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/UrlShortener@master] Use SidebarBeforeOutput hook to add sidebar link

https://gerrit.wikimedia.org/r/598958

Change 598958 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Use SidebarBeforeOutput hook to add sidebar link

https://gerrit.wikimedia.org/r/598958

Jdlrobson closed this task as Resolved.May 27 2020, 8:48 PM

Thank you for taking care of this one @Ammarpad - I'm very happy to have your help here!

Change 599445 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/UrlShortener@master] Use SkinTemplateToolboxEnd hook to add sidebar link to legacy skin.

https://gerrit.wikimedia.org/r/599445

Change 599445 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Add array key to sidebar entry.

https://gerrit.wikimedia.org/r/599445