UrlShortener should use the SidebarBeforeOutput hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 26 2020, 8:22 PM

Description

The UrlShortener extension currently uses the BaseTemplateToolbox hook to add a link to the sidebar.

The SIdebarBeforeOutput hook now includes the toolbox and languages links so can be used to add to this array and should use that hook instead, per the deprecation plan of BaseTemplateToolbox (T253416)

Details

	Subject	Repo	Branch	Lines +/-
	Add array key to sidebar entry.	mediawiki/extensions/UrlShortener	master	+5 -2
	Use SidebarBeforeOutput hook to add sidebar link	mediawiki/extensions/UrlShortener	master	+14 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Ammarpad	T254431 Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook
Resolved	Ammarpad	T254433 Collection should not use SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook
Resolved	Ammarpad	T253809 [EPIC] Deprecate the BaseTemplate hooks
Resolved	Ammarpad	T253416 Deprecate BaseTemplateToolbox hook
Resolved	Ammarpad	T253683 UrlShortener should use the SidebarBeforeOutput hook

Event Timeline

Jdlrobson created this task.May 26 2020, 8:22 PM

Ammarpad claimed this task.May 27 2020, 6:09 AM

Peachey88 added a project: MediaWiki-extensions-UrlShortener.May 27 2020, 6:49 AM

Aklapper removed a project: MediaWiki-User-Interface.May 27 2020, 7:46 AM

Change 598958 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/UrlShortener@master] Use SidebarBeforeOutput hook to add sidebar link

https://gerrit.wikimedia.org/r/598958

gerritbot added a project: Patch-For-Review.May 27 2020, 8:04 AM

Change 598958 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Use SidebarBeforeOutput hook to add sidebar link

https://gerrit.wikimedia.org/r/598958

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).May 27 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 27 2020, 10:10 AM

Thank you for taking care of this one @Ammarpad - I'm very happy to have your help here!

Thanks too @Jdlrobson

Change 599445 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/UrlShortener@master] Use SkinTemplateToolboxEnd hook to add sidebar link to legacy skin.

https://gerrit.wikimedia.org/r/599445

gerritbot added a project: Patch-For-Review.May 28 2020, 9:15 PM

Change 599445 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Add array key to sidebar entry.

https://gerrit.wikimedia.org/r/599445

Maintenance_bot removed a project: Patch-For-Review.May 30 2020, 8:10 AM