Maniphest T253809

[EPIC] Deprecate the BaseTemplate hooks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 27 2020, 8:52 PM

Tags

Referenced Files

None

Subscribers

Tokens

"Like" token, awarded by Volker_E."Like" token, awarded by Mainframe98.

Description

The following hooks are too closely coupled to the render layer meaning if a skin such as Vector that uses a different render layer (Mustache) compatibility is lost with a variety of extensions. To workaround this currently Vector inefficiently needs a corresponding SkinTemplate to keep compatibility.

The hooks in question here are:

BaseTemplateToolbox (1.35)
BaseTemplateAfterPortlet (1.35)
SkinTemplateToolboxEnd (1.35)

Sign off steps

Ensure all subtasks are closed
Make a task for any necessary hard deprecations.
EMail wikitech-l detailing what's happened

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ammarpad	T254431 Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook
		Resolved		Ammarpad	T254433 Collection should not use SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook
		Resolved		Ammarpad	T253809 [EPIC] Deprecate the BaseTemplate hooks
		Resolved		Ammarpad	T253416 Deprecate BaseTemplateToolbox hook
		Resolved		Ammarpad	T253683 UrlShortener should use the SidebarBeforeOutput hook
		Resolved		Jdlrobson	T253684 MachineVision should use the SidebarBeforeOutput hook
		Resolved		Ammarpad	T253685 WikibaseRepo should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox
		Resolved		Ammarpad	T253687 CiteThisPage should use the SidebarBeforeOutput hook
		Resolved		Mainframe98	T254218 Translate should use the SidebarBeforeOutput hook
		Resolved		Ammarpad	T254548 Regression: Tool "User uploads" in the sidebar missing in skin Monobook
		Resolved		Ammarpad	T254565 ArticlePlaceholder should use the SidebarBeforeOutput hook
		Resolved		Ammarpad	T254485 Regression: Wikidata item missing in Monobook (WikibaseClient should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox)
		Resolved		Mainframe98	T253797 BaseTemplateAfterPortlet is replaced with SkinAfterPortlet
		Duplicate		None	T254426 Wikibase Client should use SkinAfterPortlet hook instead of BaseTemplateAfterPortlet
		Resolved		Ammarpad	T253783 [EPIC] Deprecate SkinTemplateToolboxEnd hook in favor of SidebarBeforeOutput hook
		Resolved		Ammarpad	T254419 Add support for language/toolbox SidebarBeforeOutput hook to Timeless

Event Timeline

Jdlrobson created this task.May 27 2020, 8:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2020, 8:52 PM

Jdlrobson added subtasks: T253416: Deprecate BaseTemplateToolbox hook, T253797: BaseTemplateAfterPortlet is replaced with SkinAfterPortlet, T253783: [EPIC] Deprecate SkinTemplateToolboxEnd hook in favor of SidebarBeforeOutput hook.May 27 2020, 8:53 PM

Mainframe98 awarded a token.May 27 2020, 8:57 PM

Volker_E awarded a token.Jun 1 2020, 7:05 PM

Volker_E added a subscriber: Isarra.

Ammarpad added a subtask: T254426: Wikibase Client should use SkinAfterPortlet hook instead of BaseTemplateAfterPortlet.Jun 4 2020, 5:34 AM

Ammarpad added a subtask: T254485: Regression: Wikidata item missing in Monobook (WikibaseClient should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox).Jun 4 2020, 2:33 PM

Jdlrobson closed subtask T254485: Regression: Wikidata item missing in Monobook (WikibaseClient should use the SidebarBeforeOutput hook instead of BaseTemplateToolbox) as Resolved.Jun 5 2020, 8:38 PM

Jdlrobson triaged this task as Medium priority.Jun 5 2020, 8:50 PM

Ammarpad mentioned this in T252841: Update the method Wikibase uses to inject edit language links into the language portlet.Jun 6 2020, 5:57 AM

Jdlrobson lowered the priority of this task from Medium to Low.Jun 6 2020, 6:37 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Phase 1 - simplify hook contracts to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jun 6 2020, 11:47 PM

Ammarpad removed a subtask: T254426: Wikibase Client should use SkinAfterPortlet hook instead of BaseTemplateAfterPortlet.Jun 8 2020, 6:26 AM

Jdlrobson closed subtask T253797: BaseTemplateAfterPortlet is replaced with SkinAfterPortlet as Resolved.Jun 9 2020, 10:22 PM

Jdlrobson changed the status of subtask T253416: Deprecate BaseTemplateToolbox hook from Open to Stalled.Jun 10 2020, 11:59 PM

Jdlrobson changed the status of subtask T253416: Deprecate BaseTemplateToolbox hook from Stalled to Open.Jun 11 2020, 8:20 PM

Ammarpad claimed this task.Jun 12 2020, 2:18 PM

Jdlrobson closed subtask T253416: Deprecate BaseTemplateToolbox hook as Resolved.Jun 13 2020, 3:49 PM

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.Jun 15 2020, 9:55 PM

Jdlrobson raised the priority of this task from Low to Medium.Jun 15 2020, 11:22 PM

Ammarpad updated the task description. (Show Details)Jun 15 2020, 11:25 PM

Jdlrobson closed subtask T253783: [EPIC] Deprecate SkinTemplateToolboxEnd hook in favor of SidebarBeforeOutput hook as Resolved.Jun 15 2020, 11:51 PM

Jdlrobson added a project: Technical-Debt (Deprecation process).

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jun 15 2020, 11:55 PM

Opened T256509, T256510, T256511 for removing these hooks.
wikitech-l email blocked on T60137

I sent the email to wikitech-l:
https://lists.wikimedia.org/pipermail/wikitech-l/2020-June/093556.html

(We did it!)