Page MenuHomePhabricator

`tag` log entries should reference tag id rather than name
Open, Needs TriagePublic

Description

tag log entries should reference tag id rather than name, so that change tags can be renamed

This will require:

  • Updating the logging code
  • Adding a maintenance script to convert old entries
    • For each tag in the log entry, fetch the id for the text stored
  • Updating the display code
    • For each tag in the log entry, fetch the text to show based on the id

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

When a tag is deleted, it is also completely from the database, including the definition the log entries would refer to. So these references will become invalid (unless there is some special treatment).

When a tag is deleted, it is also completely from the database, including the definition the log entries would refer to. So these references will become invalid (unless there is some special treatment).

In that case, a potential solution that solves for both tags being deleted and backwards compatibility:

  • When a tag is deleted, remove the id and replace it with the tag's final name

This would also mean that existing log entries don't need to be updated, though any existing log entries not migrated wouldn't be updated if tag names change

eprodromou subscribed.

I'm moving to feature requests; this seems like it has a lot of aspects we'd need to deal with.

We discussed; Volunteer Needed makes more sense

Does that mean this is approved?