Page MenuHomePhabricator

WIP: Replace LanguageConverter ::convertTitle and ::convertNamespace in favour of ConverterHelper's and deprecate
Closed, InvalidPublic2 Estimated Story Points

Description

Story

When I need to call convertTitle and convertNamespace I want to use it from ConverterHelper, so that it's possible to deprecate them from LanguageConveter

Context

ConverterHelper was introduced as part of T253849 to make LanguageConverter simpler, so as of now all clients should call convertTitle and convertNamespace from ConverterHelper

Expected Result
  • All calls to convertTitle and convertNamespace should be linked to ConverterHelper
  • LanguageConverter ::convertTitleconvertNamespace and ::convertNamespace should be marked as deprecated
  • RELEASE_NOTES should be updated accordingly

Event Timeline

@Helga_sf would it be possible to assign a priority to this task?

Helga_sf triaged this task as Medium priority.Jun 5 2020, 3:55 PM

@Naike sure, this task belongs to User Story with less priority, so that we think it is Medium. Corrected.

Change 603002 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] language: replace the use of LanguageConverter ::convertTitle and ::convertNamespace

https://gerrit.wikimedia.org/r/603002

Helga_sf renamed this task from Replace LanguageConverter ::convertTitle and ::convertNamespace in favour of ConverterHelper's and deprecate to WIP: Replace LanguageConverter ::convertTitle and ::convertNamespace in favour of ConverterHelper's and deprecate.Jun 11 2020, 11:27 AM

Change 603002 abandoned by Peter.ovchyn:
language: replace the use of LanguageConverter ::convertTitle and ::convertNamespace

Reason:
Abandon this approach in favour of https://gerrit.wikimedia.org/r/c/mediawiki/core/ /605575

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /603002

Closed due irrelevance. The new approach is in the task: T256975