CheckUser is using UserGroupMembership::getGroupMemberships for foreign wikis
Closed, ResolvedPublic
Actions

Description

After introduction of the UserGroupManager this will not work as expected. CheckUser needs to be updated to use UserGroupManagerFactory to obtain a manager for a correct domain.

https://gerrit.wikimedia.org/r/c/604047 fixes it.

Details

	Subject	Repo	Branch	Lines +/-
	Use UserGroupManagerFactory with correct domain to fetch groups	mediawiki/extensions/CheckUser	wmf/1.35.0-wmf.36	+35 -14

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Pchelolo	T234921 Factor group membership management out of User class
Resolved	Release	jeena	T254173 1.35.0-wmf.36 deployment blockers
Resolved		• Pchelolo	T254912 CheckUser is using UserGroupMembership::getGroupMemberships for foreign wikis

Event Timeline

• Pchelolo created this task.Jun 9 2020, 4:27 PM

• Pchelolo added a parent task: T254173: 1.35.0-wmf.36 deployment blockers.

Agusbou2015 subscribed.Jun 9 2020, 5:21 PM

@Pchelolo can this close since patch is merged?

• Pchelolo closed this task as Resolved.Jun 9 2020, 5:44 PM

377f582 didn't make it in before the branch cut, so this needs to be backported.

Change 604096 had a related patch set uploaded (by Jforrester; owner: Ppchelko):
[mediawiki/extensions/CheckUser@wmf/1.35.0-wmf.36] Use UserGroupManagerFactory with correct domain to fetch groups

https://gerrit.wikimedia.org/r/604096

gerritbot added a project: Patch-For-Review.Jun 9 2020, 5:51 PM

Change 604096 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@wmf/1.35.0-wmf.36] Use UserGroupManagerFactory with correct domain to fetch groups

https://gerrit.wikimedia.org/r/604096

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-09T18:13:06Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.36/extensions/CheckUser/: T234921 T254912 Use UserGroupManagerFactory with correct domain to fetch groups (duration: 02m 26s)