Page MenuHomePhabricator

CheckUser is using UserGroupMembership::getGroupMemberships for foreign wikis
Closed, ResolvedPublic

Description

After introduction of the UserGroupManager this will not work as expected. CheckUser needs to be updated to use UserGroupManagerFactory to obtain a manager for a correct domain.

https://gerrit.wikimedia.org/r/c/604047 fixes it.

Event Timeline

@Pchelolo can this close since patch is merged?

Pchelolo closed this task as Resolved.Jun 9 2020, 5:44 PM
Jdforrester-WMF reopened this task as Open.Jun 9 2020, 5:48 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

377f582 didn't make it in before the branch cut, so this needs to be backported.

Change 604096 had a related patch set uploaded (by Jforrester; owner: Ppchelko):
[mediawiki/extensions/CheckUser@wmf/1.35.0-wmf.36] Use UserGroupManagerFactory with correct domain to fetch groups

https://gerrit.wikimedia.org/r/604096

Change 604096 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@wmf/1.35.0-wmf.36] Use UserGroupManagerFactory with correct domain to fetch groups

https://gerrit.wikimedia.org/r/604096

Mentioned in SAL (#wikimedia-operations) [2020-06-09T18:13:06Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.36/extensions/CheckUser/: T234921 T254912 Use UserGroupManagerFactory with correct domain to fetch groups (duration: 02m 26s)

Jdforrester-WMF closed this task as Resolved.Jun 9 2020, 6:15 PM

Now deployed.