Page MenuHomePhabricator
Create Task
Maniphest T255444

Regression: Sidebar "User uploads" link now missing from Commons user pages
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Visit a user page on Wikimedia Commons, for instance https://commons.wikimedia.org/wiki/User:Bjh21, and look for "User uploads" under "Toolbox" in the sidebar.

Actual Results:

There is no link labelled "User uploads"

Expected Results:

There should be a link labelled "User uploads" linking to a list of uploads by the user whose user page I'm looking at.

This link is meant to be provided by the UploadsLink extension. Apparently it recently broke in the Monobook skin (T254548), but now it seems to be broken in Vector as well.

Details

SubjectRepoBranchLines +/-
skins: Make the SidebarBeforeOutput hook non-abortablemediawiki/coremaster+6 -5
Ensure hook callback does not abort SidebarBeforeOutputmediawiki/extensions/CiteThisPagemaster+23 -25
Ensure hook callback does not abort SidebarBeforeOutputmediawiki/extensions/UploadsLinkmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

bjh21 created this task.Jun 15 2020, 2:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 2:10 PM
Ammarpad subscribed.Jun 15 2020, 3:50 PM

Did you see the link with MonoBook? (or any other skin). It seems all are not displaying it, but I cannot reproduce it locally after checking out the relevant changes per https://commons.wikimedia.org/wiki/Special:Version

Ammarpad added a subscriber: Jdlrobson.Jun 15 2020, 3:51 PM
bjh21 added a comment.Jun 15 2020, 5:29 PM

I didn't get the link in Monobook either. The Timeless skin includes a suitable link, but it's just labelled "Uploads" so I think it's generated by some different route.

Jdlrobson added a comment.EditedJun 15 2020, 5:32 PM

Mmm I also can't replicate this locally but can on the beta cluster. I wonder if another extension or configuration is altering it's behaviour.

Jdlrobson renamed this task from "User uploads" link now missing from Commons user pages in Vector skin to Regression: "User uploads" link now missing from Commons user pages in Vector skin.Jun 15 2020, 5:32 PM
Ammarpad added a comment.Jun 15 2020, 5:36 PM
In T255444#6224934, @bjh21 wrote:

I didn't get the link in Monobook either. The Timeless skin includes a suitable link, but it's just labelled "Uploads" so I think it's generated by some different route.

That's a different link. Other skins are displaying that one too.

Speravir subscribed.Jun 16 2020, 12:03 AM

What did it supposedly link to? Could it be that someone considered this as duplicative? Because, in Vector I can on every user page find two links behind the “More” menu (which is in the sidebar for the other skins I think): one named “Uploads” with a link to Special:ListFiles/<username>, and one named “Contributions” linking to Special:Contributions/<username>. Because of this I never missed the line in the sidebar.

Ammarpad renamed this task from Regression: "User uploads" link now missing from Commons user pages in Vector skin to Regression: Sidebar "User uploads" link now missing from Commons user pages.Jun 16 2020, 12:07 AM
Jdlrobson mentioned this in T254548: Regression: Tool "User uploads" in the sidebar missing in skin Monobook.Jun 16 2020, 12:11 AM
bjh21 added a comment.Jun 16 2020, 10:59 AM

The links on the "More" menu are added by a gadget; I've not managed to work out which one. This seems to mean that they're only available to logged-in users. The sidebar link provided by UploadsLink goes to /w/index.php?title=Special:ListFiles/<username>?ilshowall=1, so it's not quite the same as the link in the "More" menu.

Jdlrobson added a comment.Jun 16 2020, 11:00 PM

I have no idea why this is happening but we are talking about the user uploads link in the toolbox in the sidebar.

It shows for me locally:

Screen Shot 2020-06-16 at 3.56.32 PM.png (178×294 px, 18 KB)

but not in the beta cluster. Spent another hour looking into this today but can't see anything obvious :(

I suspect something is going wrong inside The method Skin::getRelevantUser however I have no idea how to debug why. Other extensions are not having this issue - CiteThisPage for example adds the toolbox link fine but doesn't rely on this method.

Ammarpad triaged this task as High priority.EditedJun 16 2020, 11:13 PM

Even though this is not a critical feature, I think we need to know why this happened and from where it started.

Ammarpad claimed this task.Jun 17 2020, 12:09 AM
gerritbot added a comment.Jun 17 2020, 12:42 AM

Change 606045 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CiteThisPage@master] Ensure hook callback does not abort SidebarBeforeOutput

https://gerrit.wikimedia.org/r/606045

gerritbot added a project: Patch-For-Review.Jun 17 2020, 12:42 AM
gerritbot added a comment.Jun 17 2020, 12:50 AM

Change 606046 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Clarify hook documentation

https://gerrit.wikimedia.org/r/606046

gerritbot added a comment.Jun 17 2020, 1:01 AM

Change 606052 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/UploadsLink@master] Ensure hook callback does not abort SidebarBeforeOutput

https://gerrit.wikimedia.org/r/606052

gerritbot added a comment.Jun 17 2020, 1:39 AM

Change 606052 merged by jenkins-bot:
[mediawiki/extensions/UploadsLink@master] Ensure hook callback does not abort SidebarBeforeOutput

https://gerrit.wikimedia.org/r/606052

Ammarpad mentioned this in rEULK299b5ac4ee83: Ensure hook callback does not abort SidebarBeforeOutput.Jun 17 2020, 1:40 AM
gerritbot added a comment.Jun 17 2020, 1:42 AM

Change 606045 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] Ensure hook callback does not abort SidebarBeforeOutput

https://gerrit.wikimedia.org/r/606045

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 17 2020, 2:00 AM
Jdlrobson closed this task as Resolved.Jun 17 2020, 8:33 PM

The link is now showing on https://commons.wikimedia.beta.wmflabs.org/wiki/User:Jdlrobson and https://commons.wikimedia.beta.wmflabs.org/wiki/User:Jdlrobson?useskin=monobook

Well done @Ammarpad for tracking this down.

gerritbot added a comment.Jun 28 2020, 8:42 PM

Change 606046 merged by jenkins-bot:
[mediawiki/core@master] skins: Make the SidebarBeforeOutput hook non-abortable

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /606046

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 28 2020, 9:00 PM
Speravir unsubscribed.Jun 30 2020, 6:49 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2020, 8:16 PM
Jdlrobson mentioned this in T258986: Requesting +2 rights for Mediawiki Group for Ammarpad.Jul 28 2020, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL