Page MenuHomePhabricator

Implement preliminary javascript frontend for Special:GlobalWatchlist
Closed, ResolvedPublic10 Estimated Story Points

Description

Functional, not pretty :)

Acceptance criteria:

  • Shows changes on other wikis that the user has chosen to see

Does not require autorefresh or showing wikidata labels, those will be re-added later

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 605817 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] [WIP] Special:GlobalWatchlist works

https://gerrit.wikimedia.org/r/605817

Change 606028 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Split common css for both special pages to separate file

https://gerrit.wikimedia.org/r/606028

DannyS712 added a subscriber: ashley.

@ashley this is ready for review. If possible, I would recommend getting CentralAuth set up locally to fully try it out

DannyS712 set the point value for this task to 10.Jun 17 2020, 6:26 AM

Change 606028 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Split common css for both special pages to separate file

https://gerrit.wikimedia.org/r/606028

@Tchanders I've added you as a reviewer to the patch, since @Niharika suggested that you may be interested in reviewing this work. Can you take a look?

Change 605817 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Special:GlobalWatchlist - create front end for basic global watchlist

https://gerrit.wikimedia.org/r/605817

DannyS712 claimed this task.
DannyS712 updated the task description. (Show Details)
DannyS712 set Final Story Points to 18.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.

Testing:

Special:GlobalWatchlist shows changes from multiple sites

Hi @DannyS712. Is there a way that I can inform your about some problematic issues in GW, that were irrelevant to the script, but are very relevant to the extension? I ask here, because some of them are a part of the functional frontend.

Hi @DannyS712. Is there a way that I can inform your about some problematic issues in GW, that were irrelevant to the script, but are very relevant to the extension? I ask here, because some of them are a part of the functional frontend.

Yes, but I'd wait until its more complete - the extension is very much not done yet

Yes, but I'd wait until its more complete - the extension is very much not done yet

Why? Isn't it better to create the same problem second time? You can get my opinion, and read it whenever you want.

Yes, but I'd wait until its more complete - the extension is very much not done yet

Why? Isn't it better to create the same problem second time? You can get my opinion, and read it whenever you want.

Because I'd like to wait until the current development is complete before tackling unexpected work (cf Unplanned-Sprint-Work)

Because I'd like to wait until the current development is complete before tackling unexpected work (cf Unplanned-Sprint-Work)

I see. Very well. But one of them is a bug, not an unexpected work. I never told you about it, because it's tolerable for a script, but it will be awful for the extension. Ping me when you will be ready.

Because I'd like to wait until the current development is complete before tackling unexpected work (cf Unplanned-Sprint-Work)

I see. Very well. But one of them is a bug, not an unexpected work. I never told you about it, because it's tolerable for a script, but it will be awful for the extension. Ping me when you will be ready.

Fine, I'll bite - what is the bug?

If on particular wiki some page was created and then edited, the script shows two lines, one for creation diff, and one for all the rest.

If on particular wiki some page was created and then edited, the script shows two lines, one for creation diff, and one for all the rest.

Yes, that is a known issue that will be handled when I refactor the utils to count "new" entries as edits as well