Colons get prepended when switching between input modes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Jun 18 2020, 2:53 AM

Description

This task is about the : that are being prepended to each line in the following scenario...

Behavior

Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
Click any "Reply" link to open the tool
In source mode, enter the following:

Lorem
Ipsum
{{quote|Quoted text}}
More text

Switch to the visual mode
Switch back to the source mode

Actual

❗️Notice : is added to the the line that contains the {{Quote}} template and each line above it:

:Lorem
:Ipsum
:{{quote|Quoted text}}
More text

Switch to the visual mode

Expected

✅Notice no : are visible in the comment:

Lorem
Ipsum
{{quote|Quoted text}}
More text``

Related Objects

Mentioned Here: T317352: Remove switching restrictions
T255740: Template swallows other parts of comment

Event Timeline

ppelberg created this task.Jun 18 2020, 2:53 AM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptJun 18 2020, 2:53 AM

ppelberg moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 18 2020, 2:54 AM

ppelberg renamed this task from Colons get preprended when switching between input modes to Colons get prepended when switching between input modes.Jun 18 2020, 2:56 AM

ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 18 2020, 5:03 AM

Kaartic subscribed.Jun 18 2020, 10:34 AM

Every time you switch back and forth, an additional set of colons is inserted. Try it: Switch to Source (so you can see the first colons). Now click Visual and then Source again, and repeat that several times. Notice that you have a lot more colons now.

In T255742#6235684, @Whatamidoing-WMF wrote:

Every time you switch back and forth, an additional set of colons is inserted.

Exactly. I mentioned this in my feedback too.

This particular issue is due to the template on beta being broken. On live the only issue you get is T255740#6244596

In T255742#6244600, @Esanders wrote:

This particular issue is due to the template on beta being broken. On live the only issue you get is T255740#6244596

Confirmed [1]. I'm moving this to "Needs discussion" for the time being.

Screen Shot 2020-06-22 at 6.48.10 PM.png (1×1 px, 146 KB)

ppelberg moved this task from Ready for Development to Needs Discussion / Investigation on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 23 2020, 1:50 AM

MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:59 PM

ppelberg removed a project: Editing-team (Kanban Board).Jul 11 2020, 12:12 AM

ppelberg moved this task from Required after release to Freezer on the OWC2020 (OWC2020 Replying 2.0) board.Jul 11 2020, 1:11 AM

VPuffetMichel removed a project: OWC2020 (OWC2020 Replying 2.0).Sep 8 2022, 3:41 PM

We have since prevented users switching to visual mode when templates are being used, so this isn't an issue any more. If we do add support templates in the future, it would be by encapsulating the whole comment and it is unlikely this bug would come back.

See T317352

	F31875854: Screen Shot 2020-06-22 at 6.48.10 PM.png
	Jun 23 2020, 1:50 AM

	F35513669: image.png
	Sep 8 2022, 5:03 PM

Colons get prepended when switching between input modesClosed, ResolvedPublicActions

Description

Behavior

Related Objects

Event Timeline

Colons get prepended when switching between input modes
Closed, ResolvedPublic
Actions