Page MenuHomePhabricator

Regression: Wikidata link has disappeared from advanced mobile mode
Closed, ResolvedPublic

Description

Reported on wiki.

Developer notes

Looks like the problem here is the use of the deprecated BaseTemplate::getToolbox method
This line needs to be changed:

	$tpl->set( 'pageActionsMenu', $pageActionsDirector->buildMenu( $tpl->getToolbox() ) );

It should use $skin->buildSidebar() to get the toolbox.

QA steps

Testing on mobile:
With AMC mode enabled, a wikidata link should appear in the page actions overflow menu (alongside edit) https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert%20Einstein

QA Results - Beta

ACStatusDetails
1T256272#6264795

QA Results - Prod

ACStatusDetails
1T256272#6275285

Event Timeline

Jdlrobson renamed this task from Wikidata link has disappeared from advanced mobile mode to Regression: Wikidata link has disappeared from advanced mobile mode.Jun 25 2020, 4:29 PM
Jdlrobson updated the task description. (Show Details)

Change 608002 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Minerva: Remove usage of two deprecated methods

https://gerrit.wikimedia.org/r/608002

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Ammarpad.

Change 608002 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Minerva: Remove usage of two deprecated methods

https://gerrit.wikimedia.org/r/608002

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhone 11 Pro Max

Test Artifact(s):

QA steps

Testing on mobile:
✅ AC1: With AMC mode enabled, a wikidata link should appear in the page actions overflow menu (alongside edit) https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert%20Einstein

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhone 11 Pro Max

Test Artifact(s):

QA steps

Testing on mobile:
✅ AC1: With AMC mode enabled, a wikidata link should appear in the page actions overflow menu (alongside edit) https://en.m.wikipedia.org/wiki/Albert_Einstein