Page MenuHomePhabricator

Restrict editing access of JsonConfig's "Config" namespace on Wikimedia wikis
Closed, DeclinedPublic

Description

Problem
As mentioned in T252859#6225636, it is currently possible for anyone to modify pages in the Config namespace.

Proposed Solution
Set wgNamespaceProtection for NS_CONFIG on Wikimedia's wikis to the same configuration as NS_MEDIAWIKI.

Event Timeline

dbarratt renamed this task from Restrict editing access to the Config namespace on Wikimedia wikis to Restrict editing access of the Config namespace on Wikimedia wikis.Jun 24 2020, 3:55 PM
Aklapper renamed this task from Restrict editing access of the Config namespace on Wikimedia wikis to Restrict editing access of JsonConfig's "Config" namespace on Wikimedia wikis.Jun 24 2020, 4:04 PM

@Ammarpad are you planning on working on this? I imagine the patch should be pretty simple. Only thought I had was that the NS_CONFIG (constant) might not be defined yet. So we could either conditionally define it (i.e. if it's not already) or just use whatever the integer it maps to in the extension.

@dbarratt, yes the constant will not be available there. I don't think we need to define it and then use it (which will be only once), we can just use the raw number (as others are already doing so). Alternatively this can also be done inside the extension.json file of JsonConfig, and then let others use wgNamespaceProtection if they want to alter the protection.

Change 608212 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[operations/mediawiki-config@master] Require editinterface to edit NS_CONFIG

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608212

@dbarratt I would like to know whether this task and the patch should remain open based on the new comments in T255504

@Ammarpad Thanks for the patch. I suspect we won't be using JSONConfig after all, but let's keep this task/patch open until we're sure.

@Ammarpad thank you for doing the work on this and the patch, I think we're going to use a MediaWiki message which seems slightly better. Apologies for leading everyone astray.

Change 608212 abandoned by Ammarpad:
Require editinterface to edit NS_CONFIG

Reason:
No longer needed

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608212