Page MenuHomePhabricator
Create Task
Maniphest T256292

Switching from source to visual with a reference leads to lots of things breaking
Closed, ResolvedPublic
Actions

Description

We aren't loading the plugin code from Cite, so the reference is treated as a link, and we don't handle the auto-generated ref list well.

Expected behaviour:

  • Type foo <ref>bar</ref> in source mode
  • Switch to visual, you should have a reference and a reference list (auto-generated)
  • Switch back to source, you should have a reference and a reference list

Details

SubjectRepoBranchLines +/-
Allow non-lists to be passed to unwrapListmediawiki/extensions/DiscussionToolsmaster+37 -3
Load VisualEditor plugin modules with ReplyWidgetVisualmediawiki/extensions/DiscussionToolsmaster+9 -8
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jun 24 2020, 6:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2020, 6:08 PM
gerritbot added a comment.Jun 24 2020, 6:19 PM

Change 607583 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Load VisualEditor plugin modules with ReplyWidgetVisual

https://gerrit.wikimedia.org/r/607583

gerritbot added a project: Patch-For-Review.Jun 24 2020, 6:19 PM

Change 607584 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Allow non-lists to be passed to unwrapList

https://gerrit.wikimedia.org/r/607584

Esanders updated the task description. (Show Details)Jun 24 2020, 6:21 PM
Esanders moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
gerritbot added a comment.Jun 24 2020, 9:09 PM

Change 607583 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Load VisualEditor plugin modules with ReplyWidgetVisual

https://gerrit.wikimedia.org/r/607583

gerritbot added a comment.Jun 24 2020, 9:09 PM

Change 607584 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Allow non-lists to be passed to unwrapList

https://gerrit.wikimedia.org/r/607584

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2020, 9:10 PM
matmarex mentioned this in T256324: References may disappear in DiscussionTools when switching from visual to wikitext (or saving).Jun 24 2020, 9:34 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex added a project: Editing QA.
matmarex subscribed.

I noticed an interesting problem when testing the patches, filed as T256324 since I think that's out of scope of this task.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 24 2020, 10:00 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 30 2020, 9:33 PM
Ryasmeen removed a project: Editing QA.
• ppelberg closed this task as Resolved.Jul 9 2020, 2:46 AM
MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL