InvalidArgumentException: $entityId and $targetId must refer to the same kind of entity.
Closed, ResolvedPublic5 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.39

message

$entityId and $targetId must refer to the same kind of entity.

Impact

Quite a bit of logspam from this one in production logstash for wmf.39

Note

This happens for both Forms and Senses.

Acceptance criteria:🏕️🌟

Exception doesn't surface to user & is not logged
User gets a useful response (see comments, either a message or 303 or something similar)

Details

Request ID: 40702841-0b72-4588-8920-816cfac00737
Request URL: https://www.wikidata.org/wiki/Special:EntityData/L34757-S1.json

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(402): Wikibase\DataModel\Entity\EntityRedirect->__construct(Wikibase\Lexeme\Domain\Model\SenseId, Wikibase\Lexeme\Domain\Model\LexemeId)
#1 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(499): Wikibase\Repo\LinkedData\EntityDataRequestHandler->getEntityRevision(Wikibase\Lexeme\Domain\Model\SenseId, integer, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(276): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, OutputPage, string, Wikibase\Lexeme\Domain\Model\SenseId, integer)
#3 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(157): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, WebRequest, OutputPage)
#4 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/SpecialPage.php(580): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#5 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(string)
#6 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#7 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(986): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(543): MediaWiki->main()
#9 /srv/mediawiki/php-1.35.0-wmf.39/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.35.0-wmf.39/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

	Subject	Repo	Branch	Lines +/-
	Special:EntityData: handle sub entity redirects	mediawiki/extensions/Wikibase	master	+130 -6

Customize query in gerrit

Event Timeline

• mmodell created this task.Jul 8 2020, 6:17 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 8 2020, 6:17 PM

jeena moved this task from Untriaged to Jul 2020 on the Wikimedia-production-error board.Jul 15 2020, 6:31 PM

Still seen, and reproducible from the given URL.

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptApr 1 2021, 8:38 PM

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Apr 12 2021, 8:31 AM

Also happens for forms https://www.wikidata.org/wiki/Special:EntityData/L34757-F1.json

We suspect that the right thing to do is to let the user know that you can't refer to a subentity of a redirected entity since it might not even exist anymore. i.e. this shouldn't stack trace but should fail nicely.

Instead of failing, HTTP 303 See Other pointing to the lexeme .json might also make sense (we’re not saying it’s equivalent, but it’s related).

Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Apr 20 2021, 11:05 AM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Apr 20 2021, 11:12 AM

Addshore updated the task description. (Show Details)Apr 20 2021, 12:18 PM

Addshore updated the task description. (Show Details)

Lydia_Pintscher updated the task description. (Show Details)Apr 21 2021, 10:37 AM

Lydia_Pintscher set the point value for this task to 5.Apr 21 2021, 10:43 AM

Lydia_Pintscher moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Apr 21 2021, 11:00 AM

Lydia_Pintscher edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Apr 21 2021, 11:16 AM

Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.Apr 23 2021, 10:54 AM

Jakob_WMDE claimed this task.Apr 27 2021, 9:23 AM