Page MenuHomePhabricator
Create Task
Maniphest T258314

Remove remaining uses of Revision objects in extensions
Open, Needs TriagePublic
Actions

Description

Tracking task for fixing all of the extensions that still use Revision objects and related methods and hooks, to ease review

See https://www.mediawiki.org/wiki/Manual:Revision.php/Migration for a migration guide

See T246284: Hard deprecate the Revision class and subtasks for the hard deprecation and how uses were replaced in deployed extensions

Details

SubjectRepoBranchLines +/-
Fix removed calls to 'Revision'mediawiki/extensions/Contributorsmaster+14 -8
Remove more uses of Revision objectsmediawiki/extensions/MathSearchREL1_35+63 -21
MathIdGenerator: Reduce use of Revision objectsmediawiki/extensions/MathSearchREL1_35+7 -8
Remove more uses of Revision objectsmediawiki/extensions/MathSearchmaster+63 -21
SpecialMlpEval::revision -> revisionRecordmediawiki/extensions/MathSearchmaster+12 -9
MathIdGenerator: Reduce use of Revision objectsmediawiki/extensions/MathSearchmaster+7 -8
ArticleFeedbackv5Model: Remove use of Revision objectsmediawiki/extensions/ArticleFeedbackv5master+10 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Jul 18 2020, 7:46 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 18 2020, 7:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Projects on the User-DannyS712 board.Jul 18 2020, 7:46 AM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).
DannyS712 added a subtask: T257740: Tests failing for the master branch of EditSimilar.
gerritbot added a comment.Jul 18 2020, 7:48 AM

Change 613184 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MathSearch@master] MathIdGenerator: Reduce use of Revision objects

https://gerrit.wikimedia.org/r/613184

gerritbot added a project: Patch-For-Review.Jul 18 2020, 7:48 AM
gerritbot added a comment.Jul 18 2020, 9:42 AM

Change 613185 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ArticleFeedbackv5@master] ArticleFeedbackv5Model: Remove use of Revision objects

https://gerrit.wikimedia.org/r/613185

gerritbot added a comment.Jul 18 2020, 10:58 PM

Change 613185 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] ArticleFeedbackv5Model: Remove use of Revision objects

https://gerrit.wikimedia.org/r/613185

DannyS712 added a subtask: T258369: MathSearch CI Jobs fail.Jul 20 2020, 10:09 AM
gerritbot added a comment.Jul 23 2020, 7:19 PM

Change 613184 merged by Physikerwelt:
[mediawiki/extensions/MathSearch@master] MathIdGenerator: Reduce use of Revision objects

https://gerrit.wikimedia.org/r/613184

DannyS712 mentioned this in rEMAS25a04f29931e: MathIdGenerator: Reduce use of Revision objects.Jul 23 2020, 7:30 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 23 2020, 8:10 PM
gerritbot added a comment.Jul 23 2020, 8:45 PM

Change 615846 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MathSearch@master] SpecialMlpEval::revision -> revisionRecord

https://gerrit.wikimedia.org/r/615846

gerritbot added a project: Patch-For-Review.Jul 23 2020, 8:45 PM
gerritbot added a comment.Jul 24 2020, 5:08 AM

Change 615846 merged by Physikerwelt:
[mediawiki/extensions/MathSearch@master] SpecialMlpEval::revision -> revisionRecord

https://gerrit.wikimedia.org/r/615846

DannyS712 mentioned this in rEMASa78e21951229: SpecialMlpEval::revision -> revisionRecord.Jul 24 2020, 5:08 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 5:10 AM
gerritbot added a comment.Jul 24 2020, 6:40 AM

Change 616026 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MathSearch@master] Remove more uses of Revision objects

https://gerrit.wikimedia.org/r/616026

gerritbot added a project: Patch-For-Review.Jul 24 2020, 6:40 AM
gerritbot added a comment.Jul 24 2020, 7:38 AM

Change 616026 merged by Physikerwelt:
[mediawiki/extensions/MathSearch@master] Remove more uses of Revision objects

https://gerrit.wikimedia.org/r/616026

DannyS712 mentioned this in rEMAS3ec251287777: Remove more uses of Revision objects.Jul 24 2020, 7:39 AM
• Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Aug 6 2020, 7:38 PM
DannyS712 added a subtask: T267276: Warnings for deprecated methods are shown.Nov 5 2020, 12:23 AM
Umherirrender added a subtask: T270026: Remove use of deprecated Revision class and functions from DataTable2.Dec 13 2020, 11:09 AM
gerritbot added a comment.Jan 2 2021, 10:25 AM

Change 653160 had a related patch set uploaded (by Umherirrender; owner: DannyS712):
[mediawiki/extensions/MathSearch@REL1_35] MathIdGenerator: Reduce use of Revision objects

https://gerrit.wikimedia.org/r/653160

gerritbot added a comment.Jan 2 2021, 10:25 AM

Change 653161 had a related patch set uploaded (by Umherirrender; owner: DannyS712):
[mediawiki/extensions/MathSearch@REL1_35] Remove more uses of Revision objects

https://gerrit.wikimedia.org/r/653161

gerritbot added a comment.Jan 2 2021, 10:56 AM

Change 653160 merged by Umherirrender:
[mediawiki/extensions/MathSearch@REL1_35] MathIdGenerator: Reduce use of Revision objects

https://gerrit.wikimedia.org/r/653160

gerritbot added a comment.Jan 2 2021, 10:57 AM

Change 653161 abandoned by Umherirrender:
[mediawiki/extensions/MathSearch@REL1_35] Remove more uses of Revision objects

Reason:
Seems not needed to pass tests

https://gerrit.wikimedia.org/r/653161

Umherirrender mentioned this in rEMAS14e763a42ebd: MathIdGenerator: Reduce use of Revision objects.Jan 2 2021, 12:03 PM
Physikerwelt closed subtask T258369: MathSearch CI Jobs fail as Resolved.Feb 20 2021, 4:39 PM
cicalese closed subtask T267276: Warnings for deprecated methods are shown as Resolved.Jul 26 2021, 4:52 AM
Krinkle moved this task from Untriaged to Revision on the MediaWiki-Core-Revision-backend board.Mar 2 2022, 8:35 PM
Pppery closed subtask T270026: Remove use of deprecated Revision class and functions from DataTable2 as Resolved.Feb 4 2023, 4:57 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2023, 5:30 AM
Pppery closed subtask T257740: Tests failing for the master branch of EditSimilar as Resolved.Feb 28 2023, 10:51 PM
• Metin6201 subscribed.Mar 1 2023, 4:11 AM
gerritbot added a comment.Aug 6 2023, 8:37 AM

Change 920666 had a related patch set uploaded (by DannyS712; author: Hslater):

[mediawiki/extensions/Contributors@master] Fix removed calls to 'Revision'

https://gerrit.wikimedia.org/r/920666

gerritbot added a project: Patch-For-Review.Aug 6 2023, 8:37 AM
gerritbot added a comment.Aug 6 2023, 9:49 AM

Change 920666 merged by jenkins-bot:

[mediawiki/extensions/Contributors@master] Fix removed calls to 'Revision'

https://gerrit.wikimedia.org/r/920666

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2023, 10:14 AM
ashley mentioned this in T306900: Running maintenance/PopulateContributorsTable.php: "Error: Class 'Revision' not found".Sep 22 2023, 9:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL