| Pginer-WMF | |
| Aug 3 2020, 11:35 AM |
| F32359262: image.png | |
| Sep 22 2020, 3:51 PM |
| F32358322: image.png | |
| Sep 21 2020, 8:55 PM |
| F32358318: image.png | |
| Sep 21 2020, 8:43 PM |
| F32358259: image.png | |
| Sep 21 2020, 8:42 PM |
| F32358278: image.png | |
| Sep 21 2020, 8:42 PM |
| F32358254: image.png | |
| Sep 21 2020, 8:42 PM |
| F32358291: image.png | |
| Sep 21 2020, 8:42 PM |
| F32358300: image.png | |
| Sep 21 2020, 8:42 PM |
As part of the "Edit a sentence" step (T251928) of the Section Translation mobile editor, a translation will be loaded with the Mobile Visual Editor.
Users will edit the contents in the usual way, and leave the editor.
More details in the parent task: T251928: Section Translation Editor: Edit a sentence
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| SXEditor: First integration of visual editor | mediawiki/extensions/ContentTranslation | master | +726 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T243495 [Epic] Support for Section Translation | |||
| Open | None | T251928 Section Translation Editor: Edit a sentence | |||
| Resolved | ngkountas | T259506 Edit a sentence: Load the translation with Mobile VE |
Change 627361 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXEditor: First integration of visual editor
Change 627361 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXEditor: First integration of visual editor
@ngkountas how do I arrive at that screen?
the "Edit translation" button does nothing and the "Start with an empty sentence" doesn't as well
@Jpita Edit translation button should work right now. Visual editor loads slowly but should be visible after a while:
Issues found:
1- when we select "Start with an empty sentence, it seems that VE is going to show up but it doesn't
3- I don't understand this part
Good review, Pita. I'll add some comments below:
2- VE shows up cut when we select a link to edit
on mobile VE shows up like this (at the bottom of the page) when we select a link
On mobile links are shown like cards at the bottom. This makes good use of space since it takes the space previously used by the keyboard.
So the inspector being cropped in the first example is more an artifact of viewing the desktop version on a narrow viewport. I think this is more for the Editing team to consider whether to make use of the mobile format on narrow screens (not only based on device). If we found the issue affecting our users in any way we can ping the Editing team or explore alternatives. For now, I don't think we need to do anything in this front.
3- I don't understand this part
right now I don't see any difference when I select a word or put the cursor somewhere.
When I select a word I get this error (only happens the first time I enter the editor)
Ok. I see how the text can be ambiguous. The only aspect to check is that the text you are editing is displayed at a font-size of 18px. The 18px is larger than usual (16px), which will help users to, for example, control text selection boundaries with more precision. But this is only because of the font size, no special behavior is intended when the user performs text selection.
In any case, the javascript error should not happen.
So the inspector being cropped in the first example is more an artifact of viewing the desktop version on a narrow viewport. I think this is more for the Editing team to consider whether to make use of the mobile format on narrow screens (not only based on device). If we found the issue affecting our users in any way we can ping the Editing team or explore alternatives. For now, I don't think we need to do anything in this front.
according to your spec
The standard Mobile Visual Editor will be reused
right now is not because is not the same.
is this not something we need to fix on our end on this task?
@ngkountas can we fix the js error on this task?
So the inspector being cropped in the first example is more an artifact of viewing the desktop version on a narrow viewport. I think this is more for the Editing team to consider whether to make use of the mobile format on narrow screens (not only based on device). If we found the issue affecting our users in any way we can ping the Editing team or explore alternatives. For now, I don't think we need to do anything in this front.
according to your spec
The standard Mobile Visual Editor will be reused
right now is not because is not the same.
is this not something we need to fix on our end on this task?@ngkountas can we fix the js error on this task?
This is a VE js error which is out of our scope. Visual Editor may need some refinement for our usecase but I think that falls out of our scope generally and for sure it's not something we are planning to fix right now.
@ngkountas can you give me some more info about the error?
I'm trying to get more info from the code but it's minified