Page MenuHomePhabricator

Notification popup (mw.notify) position incorrectly in Vector 2
Open, MediumPublic

Description

When not floating the notification is quite far from the right of the screen:

image.png (403×609 px, 21 KB)

The original top position here is also quite odd, partially overlapping the tab bar. In Vector1 it is full under the tab bar.

When scrolling past the original position, the notification jumps to a fixed position which is much closer to the right:

image.png (345×577 px, 12 KB)

This also creates a problem with the user menu, when open.

The watchlist item in the user menu is hidden behind the pop-up despite you opened the user menu later:

obraz.png (520×495 px, 29 KB)

Event Timeline

The screenshots above are out of date since T260432, but it is still positioned incorrectly.

Jdlrobson added subscribers: alexhollender, Jdlrobson.

cc @alexhollender looks like this one slipped through our prioritization net as it didn't have the Vector tag.

Where should notifications appear on new vector?

cc @alexhollender looks like this one slipped through our prioritization net as it didn't have the Vector tag.

Where should notifications appear on new vector?

I think we should re-evaluate this further along in the project, but for now let's just do top-right corner:

2021-04-02 17.27.03.gif (547×1 px, 406 KB)

cc @alexhollender looks like this one slipped through our prioritization net as it didn't have the Vector tag.

Where should notifications appear on new vector?

I think we should re-evaluate this further along in the project, but for now let's just do top-right corner:

2021-04-02 17.27.03.gif (547×1 px, 406 KB)

@alexhollender - top right corner where the text ends or top right of the screen (in which case, I think that's the current behavior?)

@alexhollender - top right corner where the text ends or top right of the screen (in which case, I think that's the current behavior?)

it seems that currently it's ~13px from the left/right-edge and ~100px from the top. I think it should just be 13px from the right/left, and 13px from the top.

image.png (322×744 px, 54 KB)

ovasileva added a subscriber: ovasileva.