The screenshots above are out of date since T260432, but it is still positioned incorrectly.

cc @alexhollender looks like this one slipped through our prioritization net as it didn't have the Vector tag.

Where should notifications appear on new vector?

In T260338#6968413, @Jdlrobson wrote:

cc @alexhollender looks like this one slipped through our prioritization net as it didn't have the Vector tag.

Where should notifications appear on new vector?

I think we should re-evaluate this further along in the project, but for now let's just do top-right corner:

In T260338#6969506, @alexhollender wrote:

In T260338#6968413, @Jdlrobson wrote:

cc @alexhollender looks like this one slipped through our prioritization net as it didn't have the Vector tag.

Where should notifications appear on new vector?

I think we should re-evaluate this further along in the project, but for now let's just do top-right corner:

@alexhollender - top right corner where the text ends or top right of the screen (in which case, I think that's the current behavior?)

In T260338#6993878, @ovasileva wrote:

@alexhollender - top right corner where the text ends or top right of the screen (in which case, I think that's the current behavior?)

it seems that currently it's ~13px from the left/right-edge and ~100px from the top. I think it should just be 13px from the right/left, and 13px from the top.

@Esanders can you clarify what your expectation is here:

The watchlist item in the user menu is hidden behind the pop-up despite you opened the user menu later:

It sounds like you're suggesting that the z-index of the popup and the menu should be dependent on which appeared first on the screen.

Change 744706 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Align `mw.notify()` alerts to avoid overlapping sticky header

https://gerrit.wikimedia.org/r/744706

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/c01fbcb948/w/

@alexhollender I've repositioned the notification badge so that it doesn't interfere with the sticky header or the user menu.

With the sticky header, I was able to move it down depending on whether the header was visible or not.
With the user menu, I wasn't able to conditionally move the notification badge, so I just moved it to the right.
Is this an acceptable solution?

This change is up on patchdemo:
https://patchdemo.wmflabs.org/wikis/c01fbcb948/w/index.php?title=Paris&useskinversion=2&vectorstickyheader=1
(helps to login to see the watch star).

In T260338#7553293, @Jdrewniak wrote:

@alexhollender I've repositioned the notification badge so that it doesn't interfere with the sticky header or the user menu.

as discussed on slack, I don't think we should shift it to the left because:

• it looks weird
• I don't imagine people needing to navigate to their watchlist right after adding something to it, and even if they do the notification has a link to it
• the notification is temporary, only on the screen for a second or two

Would bottom right make sense or is that too radical?

In T260338#7553432, @Jdlrobson wrote:

Would bottom right make sense or is that too radical?

That sounds like it could work, but for now I'd rather change things as little as possible to keep design review, QA, etc. more simple. If @Volker_E and the Codex folks want to look into this globally that would be great.

@alexhollender good point, i can see how moving the notification to the left looks weird.

I like @Jdlrobson 's idea of placing the notifications at the bottom of the page, however I think that may be more work than anticipated, specifically in the scenario when the notifications are stacked one on top of the other. Then the stack would have to start from the bottom and grow upwards.

Anyway for now I left it in the corner, moving down when the sticky header is open:

Change 744706 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Align `mw.notify()` alerts to avoid overlapping sticky header

https://gerrit.wikimedia.org/r/744706

In T260338#7556947, @Jdlrobson wrote:

This can now be verified on the beta cluster. Move to sign off or needs more work.

@Jdlrobson how can I trigger a notification from the sticky header? the watchstar isn't there for me

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c01fbcb948/w/