Page MenuHomePhabricator
Create Task
Maniphest T260434

Watchlist Expiry: Temporarily watched page shows full star after publishing in VisualEditor until reload
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Description

As a Watchlist Expiry user, I want the star to remain half shaded if I choose to continue watching a page in VE, so that I do not receive confusing or misleading information about the watch status when viewing the star.

Background

Editing a temporarily watched page via VE, if you check "Watch this page" when publishing, the watch star is full. If you refresh, it shows half-filled again.

Acceptance Criteria

  • If the user is watching a page temporarily, and if they select to watch the page when editing in VE, the star should automatically display the half shade (rather than full shade until refresh)
Steps to reproduce problem
  1. Go to any page
  2. Watch temporarily
  3. Edit via the VisualEditor
  4. When clicking "Publish changes...", check "Watch this page" and publish

Expected behavior: Returns you to the article, the watch star is half-filled (unless we want the page to be permanently watched, but I suspect we don't)
Observed behavior: Returns you to the article, the watch star is full

Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (d560bee) 2020-08-14T09:17:05

Details

SubjectRepoBranchLines +/-
Watchlist: Fix updateWatchLink removing css class when action=watchmediawiki/coreREL1_35+9 -13
Start using edit api results for watchlist UI updatesmediawiki/extensions/VisualEditorREL1_35+7 -3
Watchlist: Fix updateWatchLink removing css class when action=watchmediawiki/coremaster+9 -13
Update watchlist status from API resultmediawiki/extensions/DiscussionToolsmaster+4 -4
Start using edit api results for watchlist UI updatesmediawiki/extensions/VisualEditormaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

dom_walden created this task.Aug 14 2020, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2020, 1:34 PM
dom_walden mentioned this in T259564: Watchlist Expiry: update watch status when editing via dropdown [[LARGE]].Aug 14 2020, 1:34 PM
ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Aug 14 2020, 2:36 PM
ifried updated the task description. (Show Details)Aug 14 2020, 10:43 PM
dmaza claimed this task.Aug 20 2020, 5:02 PM
ifried updated the task description. (Show Details)Aug 20 2020, 11:05 PM
ifried updated the task description. (Show Details)Aug 20 2020, 11:11 PM
ARamirez_WMF set the point value for this task to 5.Aug 20 2020, 11:14 PM
ifried added a project: VisualEditor.Aug 20 2020, 11:15 PM
ARamirez_WMF moved this task from Needs Discussion to Kanban-2020-21-Q1 on the Community-Tech board.Aug 20 2020, 11:15 PM
ARamirez_WMF edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
ifried moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 21 2020, 1:50 PM
gerritbot added a comment.Aug 24 2020, 9:54 PM

Change 622204 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/VisualEditor@master] Start using edit api results for watchlist UI updates

https://gerrit.wikimedia.org/r/622204

gerritbot added a project: Patch-For-Review.Aug 24 2020, 9:54 PM
gerritbot added a comment.Aug 26 2020, 4:22 AM

Change 622441 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] [Watchlist] Fix updateWatchLink removing css class when action=watch

https://gerrit.wikimedia.org/r/622441

Esanders subscribed.EditedAug 26 2020, 10:54 PM

FYI we have very similar logic in the DiscussionTools extension (which uses the VE API) which will need to be updated too.

I noticed that we recently broke our watchlist star behaviour in DiscussionTools though, so you will need to work on top of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/622684/.

gerritbot added a comment.Aug 26 2020, 11:32 PM

Change 622204 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Start using edit api results for watchlist UI updates

https://gerrit.wikimedia.org/r/622204

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 27 2020, 12:01 AM
• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Aug 27 2020, 4:11 PM
• ppelberg added a project: Editing-team (Tracking).
• ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
dmaza added a comment.Aug 27 2020, 7:16 PM
In T260434#6414533, @Esanders wrote:

FYI we have very similar logic in the DiscussionTools extension (which uses the VE API) which will need to be updated too.

I noticed that we recently broke our watchlist star behaviour in DiscussionTools though, so you will need to work on top of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/622684/.

You mean to add support for watchlistexpiry just like in https://gerrit.wikimedia.org/r/622204? Sorry I'm not familiar with DiscussionTools

Esanders added a comment.Aug 27 2020, 7:27 PM

Yes - we just need to update the frontend code to update the watchlist star based on the API result (it uses the same backend code).

dmaza moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 27 2020, 9:14 PM
ifried moved this task from Review/Feedback 💬 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 27 2020, 9:36 PM
ifried moved this task from Done 🏁 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.
gerritbot added a comment.Aug 28 2020, 2:51 PM

Change 623004 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Update watchlist status from API result

https://gerrit.wikimedia.org/r/623004

gerritbot added a comment.Sep 1 2020, 12:29 AM

Change 623004 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Update watchlist status from API result

https://gerrit.wikimedia.org/r/623004

gerritbot added a comment.Sep 2 2020, 7:42 PM

Change 622441 merged by jenkins-bot:
[mediawiki/core@master] Watchlist: Fix updateWatchLink removing css class when action=watch

https://gerrit.wikimedia.org/r/622441

ARamirez_WMF moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 3 2020, 5:39 PM
dom_walden added a subscriber: ifried.Sep 4 2020, 3:25 PM

@dmaza @ifried Do we also want to do this for the tooltip? At the moment, after submitting, the watch star is half-filled but the tooltip is for permanent (i.e. "Remove this page from your watchlist.", doesn't say number of days left).

ifried added a comment.EditedSep 4 2020, 5:07 PM

I believe the tooltip issue will be fixed with T261030. Is that correct, @dmaza?

In terms of priority, we should fix the tooltip issue, but it can come after the MVP/first release on September 14th. It also doesn't need to block this work, and we have discussed that this ticket can be marked as Done without the tooltip fix. While the former star behavior gave incorrect information to users, the current tooltip behavior merely gives *less* information to users.

dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.Sep 8 2020, 9:23 AM
In T260434#6436631, @ifried wrote:

I believe the tooltip issue will be fixed with T261030. Is that correct, @dmaza?

I believe this is true. I missed this comment in the code commit: ...T261030 needs to be fixed or temporarily watched items will not display the right tooltip...

In terms of priority, we should fix the tooltip issue, but it can come after the MVP/first release on September 14th. It also doesn't need to block this work, and we have discussed that this ticket can be marked as Done without the tooltip fix. While the former star behavior gave incorrect information to users, the current tooltip behavior merely gives *less* information to users.

OK, thanks.

I haven't been able to reproduce the bug in the description.

I've tested VisualEditor with and without watchlist expiry enabled. I didn't see any problems in the UI or in the logs.

I also briefly tested DiscussionTools. After submitting a reply to a temporarily watched page, the watch star is half shaded (but tooltip is incorrect).

Test environments:

dmaza added a comment.Sep 9 2020, 5:41 AM

I believe the tooltip issue will be fixed with T261030. Is that correct, @dmaza?

Yes, sorry I missed your question.

gerritbot added a comment.Sep 11 2020, 3:24 AM

Change 626527 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/VisualEditor@REL1_35] Start using edit api results for watchlist UI updates

https://gerrit.wikimedia.org/r/626527

gerritbot added a comment.Sep 11 2020, 3:43 AM

Change 626530 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@REL1_35] Watchlist: Fix updateWatchLink removing css class when action=watch

https://gerrit.wikimedia.org/r/626530

gerritbot added a comment.Sep 11 2020, 3:46 AM

Change 626527 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_35] Start using edit api results for watchlist UI updates

https://gerrit.wikimedia.org/r/626527

gerritbot added a comment.Sep 11 2020, 5:13 AM

Change 626530 merged by jenkins-bot:
[mediawiki/core@REL1_35] Watchlist: Fix updateWatchLink removing css class when action=watch

https://gerrit.wikimedia.org/r/626530

ReleaseTaggerBot added a project: MW-1.35-notes.Sep 11 2020, 6:01 AM
ifried closed this task as Resolved.Sep 11 2020, 2:02 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.

I have tested this, and the half-shaded star remains in place when I now edit in VE & select "Watch this page." I have attached a screenshot of what I see when I perform this behavior (see below). For this reason, I'm marking this ticket as Done.

Screen Shot 2020-09-11 at 10.01.30 AM.png (491×999 px, 119 KB)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 11 2020, 2:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL