Page MenuHomePhabricator
Create Task
Maniphest T260532

create graphana dashboards for the Wikidata Bridge
Closed, ResolvedPublic
Actions

Assigned To
Michael
Authored By
Lydia_Pintscher
Aug 17 2020, 12:34 PM
Tags
Referenced Files
F32190053: Screenshot_2020-08-20 Wikidata Bridge - Grafana-log.png
Aug 20 2020, 2:58 PM
F32190054: Screenshot_2020-08-20 Wikidata Bridge - Grafana.png
Aug 20 2020, 2:58 PM
F32188786: image.png
Aug 19 2020, 3:14 PM
F32188783: Screenshot_2020-08-19 Wikidata Bridge - Grafana.png
Aug 19 2020, 3:10 PM
Subscribers
Addshore
Aklapper
Lucas_Werkmeister_WMDE
Lydia_Pintscher
Michael

Description

In T231204 and T249120 we introduced tracking for the Wikidata Bridge to help us make decisions for future development. We have dashboards on grafana-labs prepared for it (linked in previous tickets) to track non-production data. We now want to also have them for the production data now that the Wikidata Bridge is deployed.

Some things could be taken from beta dashboard: https://grafana-labs.wikimedia.org/d/000000020/wikidata-and-base-on-labs

Acceptance criteria:

Details

SubjectRepoBranchLines +/-
bridge: Don't record performance in background tabsmediawiki/extensions/Wikibasemaster+41 -6
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.Aug 17 2020, 12:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2020, 12:34 PM
Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.Aug 17 2020, 12:35 PM
Michael subscribed.Aug 17 2020, 12:38 PM

A bit already exists: https://grafana.wikimedia.org/d/pVG7xcAZz/wikidata-bridge

Lydia_Pintscher added a comment.Aug 17 2020, 12:58 PM

Ah cool! I missed that.

Addshore subscribed.Aug 18 2020, 12:48 PM

We should probably look at the "beta" dashboard and carry everything over from there that is expected.
https://grafana-labs.wikimedia.org/d/000000020/wikidata-and-base-on-labs

Addshore updated the task description. (Show Details)Aug 18 2020, 12:49 PM
Addshore moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Aug 18 2020, 1:15 PM
Michael added a comment.Aug 18 2020, 1:17 PM

Also, we should double-check the existing panel as there should be some data displayed by now, even if it comes just from us playing around with it on cawiki.

Lucas_Werkmeister_WMDE subscribed.Aug 18 2020, 5:30 PM

I think I’ve fixed the Data Types dashboard on the existing panel now, other panels TBD later.

Michael mentioned this in T232584: Step 1: Production deployment checklist.Aug 19 2020, 7:48 AM
Michael added a comment.Aug 19 2020, 1:11 PM
In T260532#6393975, @Lucas_Werkmeister_WMDE wrote:

I think I’ve fixed the Data Types dashboard on the existing panel now, other panels TBD later.

Thank you! Though looking at it, I feel we may want to tweak a bit how it is displayed. Maybe increase the intervals/bins to per day?

Lydia_Pintscher added a comment.Aug 19 2020, 2:23 PM

Yeah I think per day makes more sense.

Lucas_Werkmeister_WMDE added a comment.Aug 19 2020, 3:10 PM

Well, then we get this…

Screenshot_2020-08-19 Wikidata Bridge - Grafana.png (334×910 px, 22 KB)

Doesn’t look very useful to me. I tried to add a table with total counts for the selected time range, but when I went to save it Grafana told me someone else had already edited the board.

Michael added a comment.Aug 19 2020, 3:14 PM

image.png (359×797 px, 28 KB)

I already adjusted it and I thought/intended to set the default dashboard time frame to "the last 7 days" as that would seem more useful anyway. Not sure why it shows you the last hours again?

Lucas_Werkmeister_WMDE added a comment.Aug 19 2020, 3:15 PM

Well, because I had/have &from=now-6h&to=now in the URL ^^

Michael claimed this task.Aug 20 2020, 1:16 PM
Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Michael. · View Herald TranscriptAug 20 2020, 1:16 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.EditedAug 20 2020, 1:34 PM

Added all tasks to https://grafana.wikimedia.org/d/pVG7xcAZz/wikidata-bridge.

However, the two performance metrics to the left look very strange:

  • The 99th percentile of the link-listener attach time looks way too high?
  • The percentiles for the click delay shouldn't all be always the same? -> probably just not enough data. These percentiles are aggregated per minute.
Michael updated the task description. (Show Details)Aug 20 2020, 1:50 PM
Lucas_Werkmeister_WMDE added a comment.Aug 20 2020, 2:58 PM

The link-listener attach time seems high indeed, but I think the log scale might be a bit confusing? On a linear scale, it looks clearer to me that the really high times are only short spikes:

Screenshot_2020-08-20 Wikidata Bridge - Grafana-log.png (296×910 px, 80 KB)

Screenshot_2020-08-20 Wikidata Bridge - Grafana.png (296×910 px, 37 KB)

Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 21 2020, 12:16 PM

Mh, true. I can't reproduce it with closing/restoring a tab or session. Guess we just have to accept it as a mystery for now. Moving to verification for @Lydia_Pintscher.

gerritbot added a comment.Aug 21 2020, 2:07 PM

Change 621718 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Don't record performance in background tabs

https://gerrit.wikimedia.org/r/621718

gerritbot added a project: Patch-For-Review.Aug 21 2020, 2:07 PM
gerritbot added a comment.Aug 24 2020, 11:31 AM

Change 621718 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Don't record performance in background tabs

https://gerrit.wikimedia.org/r/621718

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 24 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 24 2020, 12:10 PM
Lydia_Pintscher closed this task as Resolved.Aug 25 2020, 12:41 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits