Change 624780 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/VisualEditor@master] [POC][WIP] Implement back button warning popup

https://gerrit.wikimedia.org/r/624780

@Andrew-WMDE Just tried out the back button on the test instance! Generally it looks and is working great.

One detail I noticed though, this warning message should only show if any data has been added to the template. If it's still empty, then there is no need for a warning and it can just reset/ go back to the search.

In T260887#6440851, @ECohen_WMDE wrote:

@Andrew-WMDE Just tried out the back button on the test instance! Generally it looks and is working great.

Great!

One detail I noticed though, this warning message should only show if any data has been added to the template. If it's still empty, then there is no need for a warning and it can just reset/ go back to the search.

Just added this functionality and it should be testable on the test instance.

Note for @ECohen_WMDE: I realized there is already a design for an error state within a dialog. It's actually part of OOUI. A feature of the "process dialog". Unfortunately I couldn't find it on the official demo page. This is how it looks:

(This example is when you try to save a page in VisualEditor, but the server is gone.)

This is how the design implemented in this patch currently looks like:

It's extremely close, almost indistinguishable, which is great. \o/ There are minor differences. Margins/paddings in our design are in px, but in em in the OOUI design. The font size is the same, but the weight is not. Is it worth tweaking our design? What do you think?

@thiemowmde We quickly discussed this in the daily and it seems like a good idea to use the component if it exists, especially since we might end up adding more warnings in the end. Glad to hear there is such good consistency though! Is it possible to use the component with two buttons, one neutral and one destructive?

It's possible to have 2 buttons. One is always there and labeled "Dismiss" by default. The second button is optional and labeled "Continue" or "Try again", depending on the error.

Changing the button labels is not officially supported, but possible nevertheless.

@Andrew-WMDE: All this is part of OOUI's OO.ui.ProcessDialog. What this means is that it's hard to re-use this feature in code that is not a subclass of ProcessDialog. But as it turns out the ve.ui.MWTransclusionDialog where we need this is a ProcessDialog. \o/

Change 624780 abandoned by Awight:
[mediawiki/extensions/VisualEditor@master] [POC] Implement back button warning popup

Reason:
Moved to a gitlab branch, https://gitlab.com/wmde/mediawiki-extensions-VisualEditor/-/tree/back-button

https://gerrit.wikimedia.org/r/624780