Technical: Drop getContentTransformations and setContentTransformations in MobileContext
Closed, ResolvedPublic
Actions

Description

These two methods add unnecessary indirection to allow the Special:MobileOptions page to disable transformations that do not even run per the $isSpecialPage check inside the hook here:
https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/decbf33c9d73b09111134ef7ad46c075959f9a7b/includes/ExtMobileFrontend.php#96

sign off

the query https://codesearch.wmcloud.org/search/?q=getContentTransformations&i=nope&files=&repos= returns no results
the query https://codesearch.wmcloud.org/search/?q=setContentTransformations&i=nope&files=&repos= returns no results
the query https://codesearch.wmcloud.org/search/?q=contentTransformations&i=nope&files=&repos= returns no results

Details

	Subject	Repo	Branch	Lines +/-
	Drop ContentTransformations getter and setter	mediawiki/extensions/MobileFrontend	master	+12 -38

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
Open	None	T143189 [EPIC] Split MobileContext god object apart
Resolved	Ammarpad	T261804 Technical: Drop getContentTransformations and setContentTransformations in MobileContext

Event Timeline

Jdlrobson created this task.Sep 1 2020, 10:45 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson triaged this task as Medium priority.Sep 1 2020, 10:50 PM

Jdlrobson mentioned this in T186823: Refactor MobileFormatter class: Use IMobileTransform for all transformations.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson removed projects: MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Reading-Web-Sprint-79-Uh-oh.

Change 628577 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/MobileFrontend@master] Drop ContentTransformations getter and setter

https://gerrit.wikimedia.org/r/628577

gerritbot added a project: Patch-For-Review.Sep 20 2020, 10:36 AM

Change 628577 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Drop ContentTransformations getter and setter

https://gerrit.wikimedia.org/r/628577

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 21 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2020, 10:10 AM

Ammarpad claimed this task.Sep 21 2020, 10:10 AM

Ammarpad updated the task description. (Show Details)

👍