Page MenuHomePhabricator

[EPIC] Complete the refactor of the MobileFormatter class
Open, MediumPublic

Description

During the lead paragraph work we began a refactor of the MobileFormatter class for best testability and readability.

Code coverage of the new transforms is good:
https://doc.wikimedia.org/cover-extensions/MobileFrontend/transforms/index.html
https://doc.wikimedia.org/cover-extensions/MobileFrontend/MobileFormatter.php.html

Work (incomplete)

  • Separate the LazyLoadedImages transform from MobileFormatter (https://gerrit.wikimedia.org/r/448415)
  • Separate the LazyLoadedReferences transform from MobileFormatter
  • Separate the LegacyMainPage transform from MobileFormatter (https://gerrit.wikimedia.org/r/#/c/401786/)
  • Separate out the RemoveImages transform from MobileFormatter
  • Separate out the SectionWrapping transform from MobileFormatter
  • Review remaining transforms and their purpose (are they redundant?)
  • Add tests for AddMobileTocTransform
  • MobileContext contains many methods which should be migrated to the MobileFormatter - for example, [get|set]ContentTransformations. Review and port as appropriate

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterSeparate the LazyLoadedImages transform from MobileFormatter

Event Timeline

Jdlrobson created this task.Feb 8 2018, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2018, 7:53 PM
Jdlrobson updated the task description. (Show Details)Feb 8 2018, 7:55 PM
pmiazga added a subscriber: pmiazga.Feb 8 2018, 7:58 PM
Jdlrobson updated the task description. (Show Details)Feb 15 2018, 4:48 PM
Jdlrobson triaged this task as Medium priority.Jul 10 2018, 9:36 PM

Change 448415 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Separate the LazyLoadedImages transform from MobileFormatter

https://gerrit.wikimedia.org/r/448415

Jdlrobson updated the task description. (Show Details)Jul 27 2018, 8:38 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Change 448415 merged by Pmiazga:
[mediawiki/extensions/MobileFrontend@master] Separate the LazyLoadedImages transform from MobileFormatter

https://gerrit.wikimedia.org/r/448415

Jdlrobson updated the task description. (Show Details)