Page MenuHomePhabricator

[M] Clearing search term should reset all filters across all tabs
Closed, ResolvedPublicBUG REPORT

Description

Clearing the search term via the "X" button inside the input box should also reset all filters (across all tabs) to their initial values.

Steps to Reproduce:

  1. Type in any search term
  2. Make a selection in one or more filters to modify the results which are displayed
  3. Clear the search term via the "X" in the search input box.

Actual Results:
New searches are made using whatever filters have been previously selected.

Expected Results:

  1. Clearing the search term with the "X" button should ensure that no filters are applied to the next search
  2. Clearing the search term with the "X" button should visibly reset the filter dropdowns to their initial state

Event Timeline

@mwilliams we discussed this via Slack, but if you can confirm that this formulation is correct that would be great.

egardner renamed this task from Clearing search term should reset all filters to Clearing search term should reset all filters across all tabs.Sep 2 2020, 12:54 AM
CBogen renamed this task from Clearing search term should reset all filters across all tabs to [M] Clearing search term should reset all filters across all tabs.Sep 9 2020, 4:22 PM

Change 626516 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Allow programmatic reset of filters

https://gerrit.wikimedia.org/r/626516

Change 626516 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Allow programmatic reset of filters

https://gerrit.wikimedia.org/r/626516

Etonkovidova closed this task as Resolved.EditedSep 16 2020, 10:53 PM

Verified in commons wmf.9 - works as expected.

Note: dismissing all filter selection might be interfering with users' workflow - often users refine search terms (or perform a new search) but may decide to keep the filters.