Page MenuHomePhabricator
Create Task
Maniphest T263068

Mentor module and help module display broken on narrow desktop screens
Closed, ResolvedPublic
Actions

Description

On desktop, with a viewport width below 800px, the mentor and help modules look like this:

Screenshot from 2020-09-16 14-55-22.png (964×233 px, 47 KB)

This is not a (very) recent regression, I could reproduce this on cswiki (which is running wmf.8 right now).

Details

SubjectRepoBranchLines +/-
Fix width of sidebar modules in narrow mode in variant Amediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.9+2 -0
Fix width of sidebar modules in narrow mode in variant Amediawiki/extensions/GrowthExperimentsmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Sep 16 2020, 9:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2020, 9:57 PM
Catrope moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 16 2020, 9:57 PM
gerritbot added a comment.Sep 16 2020, 10:01 PM

Change 627925 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Fix width of sidebar modules in narrow mode in variant A

https://gerrit.wikimedia.org/r/627925

gerritbot added a project: Patch-For-Review.Sep 16 2020, 10:01 PM
gerritbot added a comment.Sep 16 2020, 11:07 PM

Change 627925 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix width of sidebar modules in narrow mode in variant A

https://gerrit.wikimedia.org/r/627925

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2020, 11:10 PM
gerritbot added a comment.Sep 16 2020, 11:16 PM

Change 627946 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.9] Fix width of sidebar modules in narrow mode in variant A

https://gerrit.wikimedia.org/r/627946

gerritbot added a project: Patch-For-Review.Sep 16 2020, 11:16 PM
gerritbot added a comment.Sep 16 2020, 11:26 PM

Change 627946 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.9] Fix width of sidebar modules in narrow mode in variant A

https://gerrit.wikimedia.org/r/627946

Stashbot mentioned this in T258008: Variant C/D: smaller start module.Sep 16 2020, 11:37 PM
Stashbot mentioned this in T258704: Variant C/D: homepage Suggested edits module changes - Desktop.
Stashbot mentioned this in T263042: [wmf.9-regression] Homepage SE - suggested-edits-card-wrapper displayed wide.

Mentioned in SAL (#wikimedia-operations) [2020-09-16T23:37:39Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.9/extensions/GrowthExperiments/: Fix styling for mobile start module (T258008); Revert wider task card on desktop (T263042, T258704); Fix width of sidebar modules in narrow mode in variant A (T263068) (duration: 01m 09s)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 17 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 12:10 AM
Tgr moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 18 2020, 8:22 PM
Tgr subscribed.

No more work left on this, I think.

Etonkovidova subscribed.Sep 22 2020, 11:42 PM

Checked in betalabs - the issue is fixed.

798x680 (Chrome) the Mentorship module and General help module duly moved to the bottom of Homepage and the vertical/horizontal scrolling is in place (click on the animated gif) :

small_screen1.gif (749×792 px, 1 MB)

Etonkovidova closed this task as Resolved.Sep 25 2020, 9:20 PM
Tgr mentioned this in T263905: Mentor and help module are too narrow on desktop Special:Homepage in new Vector.Sep 26 2020, 5:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL