Page MenuHomePhabricator

Wikifeeds should send uncachable response in case of some upstream failure
Open, LowPublic

Description

During analysis for T263043, we noticed that restbase sent varnish responses that were incomplete (which is ok - you want your service to degrade as graciously as possible), but that would also be cached by the upper layers of the infrastructure.

I think it makes sense, when working in degraded mode, to either:

  • Signal no caching should happen
  • (better) Set maxage to some low (configurable) value

I prefer the latter option as it will prevent a cascading failures propagation (AQS doesn't work, so wikifeeds sends back uncacheable responses -> wikifeeds gets swarmed itself).

Event Timeline

Joe triaged this task as Low priority.Sep 17 2020, 7:39 AM
Joe created this task.

Setting the priority to low as in production we set maxage to 5 minutes as far as I can see, which is already a reasonably short time. But it might become important if we decide to be more aggressive with this caching.

Joe removed Joe as the assignee of this task.Sep 23 2020, 8:03 AM