Find/Replace tool should not be crammed into the narrow toolbar space
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Whatamidoing-WMF
	Sep 22 2020, 4:27 PM

Description

This is not good:

Steps to reproduce:

Decide that you need to find something elsewhere on the page.
Type ⌘F
Realize that you forgot to first click outside the box, so the web browser would search the rest of the page, so the keyboard shortcut opened the in-editor Find and Replace, rather than the in-browser Find and Replace.
Notice that the Reply tool has a bug.

	Subject	Repo	Branch	Lines +/-
	Disable find-and-replace	mediawiki/extensions/DiscussionTools	master	+5 -0

@ppelberg to comment the outcome of this discussion.

The decision was to disable find/replace for now, @ppelberg to comment with reasons.

Change 630183 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Disable find-and-replace

Change 630183 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Disable find-and-replace

matmarex added a project: Skipped QA.

In T263570#6494216, @Esanders wrote:

The decision was to disable find/replace for now, @ppelberg to comment with reasons.

We are assuming:

It is more likely that in the process of drafting a comment within the Reply Tool, people will be looking for content elsewhere on the page [by way of ⌘ + F] than they are to be looking for content within the content they are writing.
- Rationale: the discussions on talk pages people are commenting on will be more complex and lengthy than the individual comments people are composing with the Reply Tool.

	F32359300: Screen Shot 2020-09-22 at 9.25.05 AM.png
	Sep 22 2020, 4:27 PM