Page MenuHomePhabricator

Find/Replace tool should not be crammed into the narrow toolbar space
Closed, ResolvedPublic

Description

This is not good:

Screen Shot 2020-09-22 at 9.25.05 AM.png (888×2 px, 125 KB)

Steps to reproduce:

  1. Decide that you need to find something elsewhere on the page.
  2. Type ⌘F
  3. Realize that you forgot to first click outside the box, so the web browser would search the rest of the page, so the keyboard shortcut opened the in-editor Find and Replace, rather than the in-browser Find and Replace.
  4. Notice that the Reply tool has a bug.

Event Timeline

@ppelberg to comment the outcome of this discussion.

Esanders added a subscriber: Esanders.

The decision was to disable find/replace for now, @ppelberg to comment with reasons.

Change 630183 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Disable find-and-replace

https://gerrit.wikimedia.org/r/630183

Change 630183 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Disable find-and-replace

https://gerrit.wikimedia.org/r/630183

The decision was to disable find/replace for now, @ppelberg to comment with reasons.

We are assuming:

  • It is more likely that in the process of drafting a comment within the Reply Tool, people will be looking for content elsewhere on the page [by way of + F] than they are to be looking for content within the content they are writing.
    • Rationale: the discussions on talk pages people are commenting on will be more complex and lengthy than the individual comments people are composing with the Reply Tool.