Drop table wikimedia_editor_tasks_targets_passed on wmf wikis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mholloway
	Sep 30 2020, 6:13 PM

Description

The wikimedia_editor_tasks_targets_passed table (in x1/wikishared) is no longer used by the WikimediaEditorTasks extension and can be dropped.

ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEditorTasks/+/544263/12/sql/drop-wikimedia_editor_tasks_targets_passed.sql
Where to run those changes: x1
When to run those changes: any time
If the schema change is backwards compatible: Yes
If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Related Objects

Mentioned Here: T235908: Remove "targets" from Suggested Edits API.

Event Timeline

• Mholloway created this task.Sep 30 2020, 6:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2020, 6:13 PM

Ping @Dbrant to confirm that the "targets"/unlocking feature of Suggested Edits on Android is no longer used and there's no further need to retain this data in the active DBs.

• Mholloway triaged this task as Low priority.Sep 30 2020, 6:17 PM

👍 confirmed

Reedy moved this task from Unsorted to Delete / Drop / Remove on the Schema-change board.Sep 30 2020, 6:31 PM

LGoto moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Oct 7 2020, 3:48 PM

The code part was done with T235908, changing tag from Schema-change to Schema-change-in-production to move it to wmf dba

Umherirrender renamed this task from Drop table wikimedia_editor_tasks_targets_passed to Drop table wikimedia_editor_tasks_targets_passed on wmf wikis.Jan 6 2022, 7:46 PM

Umherirrender updated the task description. (Show Details)

Removing Schema-change-in-production as we don't consider DROPs a schema change.

Mentioned in SAL (#wikimedia-operations) [2022-01-07T05:47:38Z] <marostegui> rename wikishared.wikimedia_editor_tasks_targets_passed on db1120 T264225

This table hasn't been written since 2019:

-rw-rw---- 1 mysql mysql 432K Oct 30  2019 wikimedia_editor_tasks_targets_passed.ibd

# mysql wikishared -e "select count(*) from wikimedia_editor_tasks_targets_passed"
+----------+
| count(*) |
+----------+
|     4904 |
+----------+

I have taken a quick mysqdldump and left it at:

cumin1001:/home/marostegui/T264225# ls -lh
total 156K
-rw-r--r-- 1 root root 156K Jan  7 05:44 wikimedia_editor_tasks_targets_passed.sql

Renamed the table on db1120:

mysql:root@localhost [wikishared]> rename table wikimedia_editor_tasks_targets_passed to T264225_wikimedia_editor_tasks_targets_passed;
Query OK, 0 rows affected (0.006 sec)

To revert this change just run this on db1120:

set session sql_log_bin=0;
 rename table T264225_wikimedia_editor_tasks_targets_passed to wikimedia_editor_tasks_targets_passed;

If nothing breaks in the next few days I will drop it everywhere next week.

• Marostegui moved this task from Ready to In progress on the DBA board.Jan 7 2022, 5:48 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-10T08:13:40Z] <marostegui> Drop table wikishared.wikimedia_editor_tasks_targets_passed T264225

Dropped from everywhere.
Reminder:

I have taken a quick mysqdldump and left it at:

cumin1001:/home/marostegui/T264225# ls -lh
total 156K
-rw-r--r-- 1 root root 156K Jan  7 05:44 wikimedia_editor_tasks_targets_passed.sql

Drop table wikimedia_editor_tasks_targets_passed on wmf wikisClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Drop table wikimedia_editor_tasks_targets_passed on wmf wikis
Closed, ResolvedPublic
Actions