Page MenuHomePhabricator

Drop table wikimedia_editor_tasks_targets_passed on wmf wikis
Closed, ResolvedPublic

Description

The wikimedia_editor_tasks_targets_passed table (in x1/wikishared) is no longer used by the WikimediaEditorTasks extension and can be dropped.

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEditorTasks/+/544263/12/sql/drop-wikimedia_editor_tasks_targets_passed.sql
  2. Where to run those changes: x1
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Event Timeline

Ping @Dbrant to confirm that the "targets"/unlocking feature of Suggested Edits on Android is no longer used and there's no further need to retain this data in the active DBs.

Umherirrender added a subscriber: Umherirrender.

The code part was done with T235908, changing tag from Schema-change to Blocked-on-schema-change to move it to wmf dba

Umherirrender renamed this task from Drop table wikimedia_editor_tasks_targets_passed to Drop table wikimedia_editor_tasks_targets_passed on wmf wikis.Thu, Jan 6, 7:46 PM
Umherirrender updated the task description. (Show Details)
Marostegui moved this task from Triage to Ready on the DBA board.
Marostegui added a subscriber: Marostegui.

Removing Blocked-on-schema-change as we don't consider DROPs a schema change.

Mentioned in SAL (#wikimedia-operations) [2022-01-07T05:47:38Z] <marostegui> rename wikishared.wikimedia_editor_tasks_targets_passed on db1120 T264225

This table hasn't been written since 2019:

-rw-rw---- 1 mysql mysql 432K Oct 30  2019 wikimedia_editor_tasks_targets_passed.ibd
# mysql wikishared -e "select count(*) from wikimedia_editor_tasks_targets_passed"
+----------+
| count(*) |
+----------+
|     4904 |
+----------+

I have taken a quick mysqdldump and left it at:

cumin1001:/home/marostegui/T264225# ls -lh
total 156K
-rw-r--r-- 1 root root 156K Jan  7 05:44 wikimedia_editor_tasks_targets_passed.sql

Renamed the table on db1120:

mysql:root@localhost [wikishared]> rename table wikimedia_editor_tasks_targets_passed to T264225_wikimedia_editor_tasks_targets_passed;
Query OK, 0 rows affected (0.006 sec)

To revert this change just run this on db1120:

set session sql_log_bin=0;
 rename table T264225_wikimedia_editor_tasks_targets_passed to wikimedia_editor_tasks_targets_passed;

If nothing breaks in the next few days I will drop it everywhere next week.

Mentioned in SAL (#wikimedia-operations) [2022-01-10T08:13:40Z] <marostegui> Drop table wikishared.wikimedia_editor_tasks_targets_passed T264225

Dropped from everywhere.
Reminder:

I have taken a quick mysqdldump and left it at:

cumin1001:/home/marostegui/T264225# ls -lh
total 156K
-rw-r--r-- 1 root root 156K Jan  7 05:44 wikimedia_editor_tasks_targets_passed.sql