[S] Tabs should not hold focus state after being clicked
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 8 2020, 2:56 PM

Description

The focus rectangle should only be used for keyboard focus, not when you click a tab:

Compare with the OOUI functionality:
https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#demo-section-tabs

Also the inactive colour is lighter than in OOUI, this should be resolved in one repo or the other.

There should also a be dark blue "pressed" state when the mouse is down.

Acceptance Criteria:

Focus rectangle is only visible on keyboard focus, not on click
Inactive tab color matches OOUI value
Dark blue "pressed" state visible while mouse is down

Details

	Subject	Repo	Branch	Lines +/-
	Only show tab focus styles on keyboard nav	mediawiki/extensions/WikibaseMediaInfo	master	+45 -23

Customize query in gerrit

Related Objects

Duplicates Merged Here: T265085: Media Search: Accessibility borders update

Event Timeline

Esanders created this task.Oct 8 2020, 2:56 PM

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptOct 8 2020, 2:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

CBogen edited projects, added Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2); removed Structured-Data-Backlog, SDAW-MediaSearch.Oct 8 2020, 3:10 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

CBogen renamed this task from Tabs should not hold focus state after being clicked to [S] Tabs should not hold focus state after being clicked.Oct 21 2020, 4:34 PM

CBogen merged a task: T265085: Media Search: Accessibility borders update.

CBogen added a subscriber: mwilliams.

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Oct 21 2020, 5:02 PM

AnneT claimed this task.Dec 4 2020, 6:34 PM

AnneT updated the task description. (Show Details)

Change 645434 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Only show tab focus styles on keyboard nav

https://gerrit.wikimedia.org/r/645434

gerritbot added a project: Patch-For-Review.Dec 4 2020, 9:25 PM

AnneT moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.Dec 4 2020, 9:27 PM

Change 645434 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Only show tab focus styles on keyboard nav

https://gerrit.wikimedia.org/r/645434

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2021, 9:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 11 2021, 10:00 PM

AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 15 2021, 9:37 PM