⚓ T265082 Special:Investigate timeline shows user links for the checkuser's IP instead of the investigated IP

	Subject	Repo	Branch	Lines +/-
	TimelineRowFormatter::getUserLinks should not assume the user is registered	mediawiki/extensions/CheckUser	master	+6 -2

Tchanders created this task.Oct 8 2020, 7:58 PM

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptOct 8 2020, 7:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks @Bsadowski1 for noticing the bug _and_ fixing the cause, I'm just a postman and patchauthor :-).

Change 633006 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/CheckUser@master] TimelineRowFormatter::getUserLinks should not assume the user is registered

https://gerrit.wikimedia.org/r/633006

gerritbot added a project: Patch-For-Review.Oct 8 2020, 7:59 PM

Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Oct 8 2020, 7:59 PM

Urbanecm added a subscriber: Bsadowski1.

DannyS712 subscribed.Oct 8 2020, 9:42 PM

Change 633006 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] TimelineRowFormatter::getUserLinks should not assume the user is registered

https://gerrit.wikimedia.org/r/633006

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 8 2020, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2020, 10:10 PM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Oct 8 2020, 11:29 PM

Niharika moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 9 2020, 2:50 AM

dom_walden mentioned this in Unknown Object (Task).Oct 9 2020, 7:24 AM

alaa subscribed.Oct 9 2020, 11:48 AM

Tchanders merged a task: Unknown Object (Task).Oct 9 2020, 1:09 PM

Tchanders moved this task from Code Review 🔍 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.

Tchanders added subscribers: Niharika, dom_walden.