Page MenuHomePhabricator

Timeless "user icon" in desktop view now displays notifications when clicked, instead of the user drop down
Closed, DuplicatePublic

Description

Not sure if this was the most recent release or earlier, but right now when you hover over the man in the top right which is ostensibly the user, what is displayed, and what displays when clicked, are the notifications rather than the user drop down.

image.png (104×262 px, 3 KB)

Event Timeline

Peachey88 renamed this task from Timeless "man" in desktop view now displays notifications when clicked, instead of the user drop down to Timeless "user icon" in desktop view now displays notifications when clicked, instead of the user drop down.Oct 17 2020, 11:16 PM
Tacsipacsi added subscribers: Jdlrobson, Tacsipacsi.

This is because the notifications have a transparent text that overlaps with the personal toolbar icon. If you’ve had a longer user name, you could use the end of the dropdown. :)

Echo overlap.png (75×224 px, 4 KB)

By the way, as a workaround, if you zoom in to get the tablet or mobile view of Timeless, the notifications text no longer overlaps and you can access the personal toolbar.

I think this regression is caused by 150fc7a16c4e, committed by @Jdlrobson.

Change 635022 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] Use skinStyles for deciding where the text-indent should apply

https://gerrit.wikimedia.org/r/635022

Change 635022 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use skinStyles for deciding where the text-indent should apply

https://gerrit.wikimedia.org/r/635022

Is it possible to deploy this in a backport window? I hope it’s not too risky, and the bug is pretty annoying, especially now that the train deployment will be in two weeks instead of one because of the server switch next week.

Change 635569 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] Timeless skinStyles should be additive not replace

https://gerrit.wikimedia.org/r/635569

The patch made things worse so shouldn't be backported until 635569 has landed.

Change 635569 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Timeless skinStyles should be additive not replace

https://gerrit.wikimedia.org/r/635569

@Jdlrobson re-checked in production and in betalabs (with Legacy Vector, new Vector and with Timeless). I checked on the desktop only - so far the issue does not seem to be fixed. Below I added the gif to illustrate the issue:

link_notices1.gif (623×566 px, 62 KB)

Production and betalabs look the same

production wmf.14betalabs
Screen Shot 2020-10-22 at 1.46.42 PM.png (146×356 px, 22 KB)
Screen Shot 2020-10-22 at 2.18.38 PM.png (143×337 px, 24 KB)

Thanks @Etonkovidova - looks like there is more work to do on T264339. Should I merge this ticket into that one?

Thanks @Etonkovidova - looks like there is more work to do on T264339. Should I merge this ticket into that one?

Yes, it makes sense - thanks!