Disable ReferencePreviews when gadget is detected
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Background
Based on investigation in T234204: Investigation: how many wikis have the ReferenceTooltip Gadget enabled by default?, we know the experience of encountering both the ReferencePreview extension and the Navigation-Popups or ReferenceTooltip gadget, which is set as default on several top 10 wikis, is a broken one. To ensure that doesn't occur, we have decided to auto-disable ReferencePreviews if the gadgets are detected.

Open questions:

How should the auto-disable detect the gadget? Based on name or another solution? Same as already done for Navigation-Popups, see T234204#5604893
Under which names does the ReferenceTooltip gadget exist on the wikis? If solution is to be based on it's name, gather list of names used on wikis that have this gadget enabled in the configuration.

Requirements:

Make our Reference Previews auto-disable when the gadget is detected. This should work both for logged-in users that have the gadget enabled, and for anynomous users on wikis in which the gadget is enabled by default.

Details

	Subject	Repo	Branch	Lines +/-
	Allow Beta preference checkboxes to be disabled	mediawiki/extensions/BetaFeatures	master	+3 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T256004 Decide if we keep the wgPopupsReferencePreviews feature switch
Resolved	awight	T282999 Enable Reference Previews on all wikis using the Popups extension, on Nov 21
Resolved	WMDE-Fisch	T282147 Enable RefPreviews on Marathi Wikipedia
Resolved	WMDE-Fisch	T271206 Enable RefPreviews on first wikis
Resolved	lilients_WMDE	T234205 Add cog wheel to the popup to disable ReferencePreviews
Resolved	WMDE-Fisch	T265709 Merge Page Preview and Reference Preview preferences
Resolved	lilients_WMDE	T265872 Disable ReferencePreviews when gadget is detected

Event Timeline

Lena_WMDE created this task.Oct 19 2020, 8:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2020, 8:21 AM

Lena_WMDE moved this task from Backlog to In preparation on the Reference Previews board.Oct 19 2020, 8:23 AM

Lena_WMDE mentioned this in T265709: Merge Page Preview and Reference Preview preferences.Oct 19 2020, 8:29 AM

Lena_WMDE updated the task description. (Show Details)Oct 19 2020, 9:28 AM

Lena_WMDE updated the task description. (Show Details)

We'll read the user's preferences to check for the gadget being enabled.

Lena_WMDE added a parent task: T265709: Merge Page Preview and Reference Preview preferences.Oct 19 2020, 9:31 AM

... which won't work for anonymous users.

This ticket should only deal with logged-in users. For anons, we just have to be careful to never configure both preview features by default.

Lena_WMDE updated the task description. (Show Details)Oct 19 2020, 9:41 AM

One more comment about this. We do need to handle the case where a wiki is configured with both Reference Tooltips and Reference Previews enabled by default. Always suppress ours in this case, as discussed here.

Lena_WMDE renamed this task from [Draft] Disable ReferencePreviews when gadget is detected to Disable ReferencePreviews when gadget is detected.Oct 19 2020, 9:42 AM

Lena_WMDE updated the task description. (Show Details)

Lena_WMDE set the point value for this task to 8.

Lena_WMDE moved this task from In preparation to Ready for pickup on the Reference Previews board.Oct 19 2020, 9:56 AM

lilients_WMDE claimed this task.Oct 28 2020, 9:45 AM

lilients_WMDE added a project: WMDE-QWERTY-Sprint-2020-10-21.Oct 28 2020, 9:52 AM

lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-10-21 board.

awight moved this task from Ready for pickup to Doing on the Reference Previews board.Oct 28 2020, 9:53 AM

Change 637531 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/BetaFeatures@master] Allow Beta preference checkboxes to be disabled

https://gerrit.wikimedia.org/r/637531

gerritbot added a project: Patch-For-Review.Oct 29 2020, 4:20 PM

Lena_WMDE moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.Oct 30 2020, 10:32 AM

Change 637531 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] Allow Beta preference checkboxes to be disabled

https://gerrit.wikimedia.org/r/637531

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 30 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2020, 6:10 PM

lilients_WMDE added a project: Unplanned-Sprint-Work.Nov 2 2020, 12:06 PM

Analogous to conflicts with navigation pop-ups we adapted the code, so that only one pop-up at a time is being displayed. This is the current state (click to start):

Peek_reference-previews_ 2020-11-02.gif (770×1 px, 1 MB)

ECohen_WMDE subscribed.Nov 3 2020, 8:35 AM

Lena_WMDE added a project: WMDE-QWERTY-Sprint-2020-11-04.Nov 4 2020, 9:11 AM

thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-11-04 board.Nov 4 2020, 9:13 AM

Lena_WMDE removed a project: Unplanned-Sprint-Work.Nov 4 2020, 9:17 AM

lilients_WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-11-04 board.Nov 11 2020, 3:22 PM

Change 638490 had a related patch set uploaded (by Svantje Lilienthal; owner: Svantje Lilienthal):
[mediawiki/extensions/Popups@master] hide reference previews when reference tooltip gadget is active

https://gerrit.wikimedia.org/r/638490

gerritbot added a project: Patch-For-Review.Nov 11 2020, 5:44 PM

lilients_WMDE mentioned this in T267951: Add test for conflict with popups.Nov 16 2020, 5:45 PM

thiemowmde moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-11-04 board.Nov 17 2020, 11:15 AM

Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-11-04 board.Nov 17 2020, 12:43 PM

Lena_WMDE closed this task as Resolved.Nov 17 2020, 12:48 PM

awight updated the task description. (Show Details)Dec 7 2020, 1:49 PM

thiemowmde mentioned this in T234204: Investigation: how many wikis have the ReferenceTooltip Gadget enabled by default?.Feb 4 2021, 1:08 PM