Enable Reference Previews on all wikis using the Popups extension, on Nov 21
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lena_WMDE
	May 17 2021, 9:02 AM

Description

We decided, that the feature is ready to leave beta feature mode.

Schedule:
Deactivate beta feature mode on all wikis on Nov. 21nd. Cleanup patches can be merged afterwards.

Acceptance criteria:

Disable BetaFeature mode
Keep the wgPopupsReferencePreviews feature switch until it's decided to remove it
Remove BetaFeature related config settings in mediawiki-config

User settings should be opt-out, so it's enabled by default
Make sure it's enabled by default for anon/IP masked temporary user*s

Note:

The feature depends on the Page-Previews extension being installed and enabled. Currently that's true only for all Wikipedia wikis and a handful exceptions. Currently the list is:

	'sewikimedia' => true, // T68374
	'wikipedia' => true,
	'enwikivoyage' => true, // T203981
	'hewikivoyage' => true, // T222017
	'zhwikivoyage' => true, // T230624
	'dewikivoyage' => true, // T264305

Follow ups:
T351708: Cleanup beta feature code in the ReferencePreviews and related
T256004: Decide if we keep the wgPopupsReferencePreviews feature switch

Details

Subject	Repo	Branch	Lines +/-
References previews is no longer a beta feature	operations/mediawiki-config	master	+0 -1
Remove all BetaFeature code from ReferencePreviews	mediawiki/extensions/Popups	master	+63 -267
Enable Reference Previews on all wikis	operations/mediawiki-config	master	+2 -22

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T256004 Decide if we keep the wgPopupsReferencePreviews feature switch
Resolved		awight	T282999 Enable Reference Previews on all wikis using the Popups extension, on Nov 21
Resolved		WMDE-Fisch	T282147 Enable RefPreviews on Marathi Wikipedia
Resolved		WMDE-Fisch	T271206 Enable RefPreviews on first wikis
Resolved		lilients_WMDE	T234205 Add cog wheel to the popup to disable ReferencePreviews
Resolved		WMDE-Fisch	T265709 Merge Page Preview and Reference Preview preferences
Resolved		lilients_WMDE	T265872 Disable ReferencePreviews when gadget is detected
Invalid		None	T267960 Update text on Preferences > Appearance > Reading preferences
Resolved		None	T233813 Separate user preferences for Page previews and Reference previews for Beta
Resolved		None	T233109 Spike: How should users enable the reference preview feature?
Resolved		None	T235737 Discuss and decide on underspecified behavior for anonymous users
Resolved		Andrew-WMDE	T277641 Collect PrefUpdate events for reference previews, remove for page previews
Resolved		lilients_WMDE	T277640 Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users
Resolved		lilients_WMDE	T277639 Settings pop up for RefPreviews and Page Previews
Resolved		Andrew-WMDE	T277638 Separate user setting for RefPreviews and Page Previews for default
Declined		None	T281698 Browser tests for Reference Previews anonymous settings dialog
Duplicate	Feature	None	T313048 Can reference tooltips be moved out of beta mode?
Resolved		None	T345833 ReferencePreviews: Final round of manual tests before full rollout
Resolved		WMDE-Fisch	T347391 Don't show ReferencePreviews together with Navigation Popups Footnote Previews
Resolved	BUG REPORT	None	T345829 Regression: Setting icon in ReferencePreview popups does nothing
Resolved		None	T347758 Replace the Reference Previews Grafana board with a Superset board fitting our needs
Resolved		WMDE-Fisch	T353798 Fix the data collection for ReferencePreviews
Resolved		None	T351314 Update the list of ReferenceTooltips and NavigationPopups gadgets
Open	BUG REPORT	None	T351497 Remove ReferencePreviews killswitch from ReferenceTooltips gadgets
Resolved		None	T351629 Get a usage baseline for gadgets conflicting with Reference Previews

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

thiemowmde added a subtask: T313048: Can reference tooltips be moved out of beta mode?.Sep 7 2023, 12:25 PM

thiemowmde mentioned this in T345833: ReferencePreviews: Final round of manual tests before full rollout.Sep 7 2023, 12:29 PM

thiemowmde added a subtask: T345833: ReferencePreviews: Final round of manual tests before full rollout.

thiemowmde added a subtask: T345829: Regression: Setting icon in ReferencePreview popups does nothing.Sep 7 2023, 3:16 PM

thiemowmde mentioned this in T346404: When reference previews is a beta feature the settings cog does not display for logged in users.Sep 15 2023, 6:56 AM

Edtadros closed subtask T345829: Regression: Setting icon in ReferencePreview popups does nothing as Resolved.Sep 18 2023, 1:23 AM

WMDE-Fisch updated the task description. (Show Details)Sep 29 2023, 11:35 AM

WMDE-Fisch renamed this task from Enable RefPreviews on all wikis to Enable Reference Previews on all wikis.Sep 29 2023, 11:38 AM

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch merged a task: T313048: Can reference tooltips be moved out of beta mode?.

WMDE-Fisch added projects: WMDE-TechWish-Maintenance, WMDE-TechWish-Maintenance-2023.

WMDE-Fisch added subscribers: Jdlrobson, Galobtter, Manuel.

WMDE-Fisch updated the task description. (Show Details)Sep 29 2023, 6:29 PM

WMDE-Fisch mentioned this in T233813: Separate user preferences for Page previews and Reference previews for Beta.

WMDE-Fisch updated the task description. (Show Details)Sep 29 2023, 6:31 PM

WMDE-Fisch updated the task description. (Show Details)Sep 29 2023, 6:35 PM

WMDE-Fisch updated the task description. (Show Details)Oct 6 2023, 11:18 AM

WMDE-Fisch closed subtask T345833: ReferencePreviews: Final round of manual tests before full rollout as Resolved.Oct 18 2023, 1:43 PM

thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Oct 20 2023, 9:02 AM

WMDE-Fisch moved this task from Backlog to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.Oct 25 2023, 12:46 PM

WMDE-Fisch moved this task from Watching / Epic to Backlog on the WMDE-TechWish-Maintenance-2023 board.

WMDE-Fisch updated the task description. (Show Details)Nov 2 2023, 2:28 PM

WMDE-Fisch claimed this task.Nov 6 2023, 8:05 AM

WMDE-Fisch moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.

WMDE-Fisch updated the task description. (Show Details)

Change 971882 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[operations/mediawiki-config@master] Enable Reference Previews on all wikis

https://gerrit.wikimedia.org/r/971882

gerritbot added a project: Patch-For-Review.Nov 6 2023, 8:13 AM

Change 971897 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@master] Remove all BetaFeature code from ReferencePreviews

https://gerrit.wikimedia.org/r/971897

Jdlrobson mentioned this in T350724: Polish Wikipedia loads almost double amount of render blocking CSS for anonymous users.Nov 7 2023, 7:20 PM

Izno subscribed.Nov 8 2023, 1:05 AM

WMDE-Fisch moved this task from Doing to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.Nov 9 2023, 8:57 AM

We should not forget to undo https://gerrit.wikimedia.org/r/493409, i.e. remove the feature from what is now wgBetaFeaturesAllowList.

Can you clarify: will it be enabled by default in wikis that already use ReferenceTooltips gadget by default? Because that seems like an unneeded overhead (assuming the preference feature doesn’t load conditionally, otherwise everything is probably fine).

Diskdance subscribed.Nov 14 2023, 5:42 AM

Has this been tested on anything that's not a Wikipedia? And does "all wikis" mean "all wikis" or "all Wikipedias" in the announced "Enable Reference Previews on all wikis"?

I'm asking because I don't recall seeing this announced or as a beta feature on English Wikisource, and while it could potentially be extremely useful for that project's content the project does use Cite quite differently from your typical Wikipedia.

In T282999#9328699, @stjn wrote:

Can you clarify: will it be enabled by default in wikis that already use ReferenceTooltips gadget by default? Because that seems like an unneeded overhead (assuming the preference feature doesn’t load conditionally, otherwise everything is probably fine).

There's code that will disable Reference Previews when the user uses the ReferenceTooltips gadget. So there should not be the overhead of two previews. The behavior can be tested already by enabling the Reference Previews beta feature. If you experience any issues with that, please let us know.

In T282999#9329382, @Xover wrote:

Has this been tested on anything that's not a Wikipedia? And does "all wikis" mean "all wikis" or "all Wikipedias" in the announced "Enable Reference Previews on all wikis"?

I'm asking because I don't recall seeing this announced or as a beta feature on English Wikisource, and while it could potentially be extremely useful for that project's content the project does use Cite quite differently from your typical Wikipedia.

Hey, thanks for the questions. Yes, technically it's "Wikipedias". The feature currently depends on the Page-Previews extension installed. And that's only true for Wikipedia wikis and a handful of exceptions. I'll update this task accordingly to make that more clear.

WMDE-Fisch renamed this task from Enable Reference Previews on all wikis to Enable Reference Previews on all wikis using the Popups extension.Nov 14 2023, 9:15 AM

WMDE-Fisch updated the task description. (Show Details)

Restricted Application added a subscriber: Stang. · View Herald TranscriptNov 14 2023, 9:15 AM

In T282999#9329552, @WMDE-Fisch wrote:

There's code that will disable Reference Previews when the user uses the ReferenceTooltips gadget. So there should not be the overhead of two previews. The behavior can be tested already by enabling the Reference Previews beta feature. If you experience any issues with that, please let us know.

I’m asking about the overhead of having a feature that does not get used load additional JS code, though.

Sure, that's one of the more important things we are responsible for as full-time developers. ☺️ Here is some of the code that does this: https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/includes/PopupsContext.php$204

Tacsipacsi subscribed.Nov 14 2023, 3:50 PM

Lectrician1 awarded a token.Nov 14 2023, 4:33 PM

Lectrician1 subscribed.

Lectrician1 unsubscribed.

We are discussing whether the timing makes sense in light of the Thansgiving holiday and the train hold: https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/FJ7EAWKEUN55FRJMFKXXMHNYNN65GS3M/

I think the lack of the train is not a problem: if problems arise on a Wednesday, that week’s train has already departed anyway, so next week is not different in that regard. (Actually, the lack of the train may be a good thing: if there was a train, the enabling would happen in a heterogeneous environment – Wikivoyages with the new version, Wikipediæ with the old one.) However, if something goes wrong, and nobody is in office to commit and deploy an emergency rollback, that could be a problem. So while no-train doesn’t seem to be a problem, you should probably not deploy on the day before Thanksgiving. A day earlier (Tuesday, Nov 21) should be safe.

WMDE-Fisch added a subtask: T351497: Remove ReferencePreviews killswitch from ReferenceTooltips gadgets.Nov 17 2023, 9:31 AM

WMDE-Fisch renamed this task from Enable Reference Previews on all wikis using the Popups extension, on Nov 22 to Enable Reference Previews on all wikis using the Popups extension, on Nov 21.Nov 20 2023, 10:56 AM

WMDE-Fisch reassigned this task from WMDE-Fisch to awight.

WMDE-Fisch moved this task from Watching / Epic to Doing on the WMDE-TechWish-Maintenance-2023 board.

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch subscribed.

In T282999#9338017, @Tacsipacsi wrote:

I think the lack of the train is not a problem: if problems arise on a Wednesday, that week’s train has already departed anyway, so next week is not different in that regard. (Actually, the lack of the train may be a good thing: if there was a train, the enabling would happen in a heterogeneous environment – Wikivoyages with the new version, Wikipediæ with the old one.) However, if something goes wrong, and nobody is in office to commit and deploy an emergency rollback, that could be a problem. So while no-train doesn’t seem to be a problem, you should probably not deploy on the day before Thanksgiving. A day earlier (Tuesday, Nov 21) should be safe.

Thanks for the nudge. We re-scheduled and aim to deploy on the 21st now.

@awight Scheduled: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=2128334&oldid=2128324

Change 971882 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Reference Previews on all wikis

https://gerrit.wikimedia.org/r/971882

Mentioned in SAL (#wikimedia-operations) [2023-11-21T08:09:37Z] <awight@deploy2002> Started scap: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-21T08:11:02Z] <awight@deploy2002> awight and wmde-fisch: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-21T08:24:39Z] <awight@deploy2002> Finished scap: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]] (duration: 15m 02s)

Mentioned in SAL (#wikimedia-operations) [2023-11-21T08:27:08Z] <awight@deploy2002> Started scap: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-21T08:28:27Z] <awight@deploy2002> wmde-fisch and awight: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-21T12:27:06Z] <awight@deploy2002> Started scap: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-21T12:28:30Z] <awight@deploy2002> wmde-fisch and awight: Backport for [[gerrit:971882|Enable Reference Previews on all wikis (T282999)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

stjn unsubscribed.Nov 21 2023, 12:28 PM

Deployed!

WMDE-Fisch updated the task description. (Show Details)Nov 21 2023, 12:56 PM

Lena_WMDE moved this task from Backlog to Ready for pickup on the Reference Previews board.Nov 21 2023, 12:57 PM

Lena_WMDE moved this task from Ready for pickup to Doing on the Reference Previews board.

Nice! Is there a User-notice planned? I imagine some projects (e.g. English Wikipedia) may want to consider whether they change the "default" option the reference previews gadget for anonymous users.

In T282999#9351190, @Jdlrobson wrote:

Nice! Is there a User-notice planned? I imagine some projects (e.g. English Wikipedia) may want to consider whether they change the "default" option the reference previews gadget for anonymous users.

Yes, there are plans to get in touch with the wikis that have a default on the relevant gadgets. Would be a great success to get rid of some of these :-)

Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2023-11-22.Nov 22 2023, 7:14 AM

Tobi_WMDE_SW moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2023-11-22 board.Nov 22 2023, 7:17 AM

Change 971897 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove all BetaFeature code from ReferencePreviews

https://gerrit.wikimedia.org/r/971897

Maintenance_bot removed a project: Patch-For-Review.Nov 24 2023, 3:10 PM

lilients_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2023-11-22 board.Dec 5 2023, 8:49 AM

Change 980901 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] References previews is no longer a beta feature

https://gerrit.wikimedia.org/r/980901

gerritbot added a project: Patch-For-Review.Dec 6 2023, 4:24 PM

I posted another patch for some code I stumbled upon while introducing a new beta feature.

In T282999#9351474, @WMDE-Fisch wrote:

In T282999#9351190, @Jdlrobson wrote:

Nice! Is there a User-notice planned? I imagine some projects (e.g. English Wikipedia) may want to consider whether they change the "default" option the reference previews gadget for anonymous users.

Yes, there are plans to get in touch with the wikis that have a default on the relevant gadgets. Would be a great success to get rid of some of these :-)

Is there a task to track this or should I add User-notice to this task? If you create a new task, could you subscribe me? (I'm monitoring this ticket as that communication impacts work I'm doing in the repo )

In T282999#9387193, @Jdlrobson wrote:

I posted another patch for some code I stumbled upon while introducing a new beta feature.

Thank, we got that covered and are planing to merge it during the current sprint. :-)
See https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/976650

Yes, there are plans to get in touch with the wikis that have a default on the relevant gadgets. Would be a great success to get rid of some of these :-)

Is there a task to track this or should I add User-notice to this task? If you create a new task, could you subscribe me? (I'm monitoring this ticket as that communication impacts work I'm doing in the repo )

No not yet. We'll keep you updated when there's movement. :-) - Thanks for taking care!

Change 980901 abandoned by Jdlrobson:

[operations/mediawiki-config@master] References previews is no longer a beta feature

Reason:

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/976650

https://gerrit.wikimedia.org/r/980901

Maintenance_bot removed a project: Patch-For-Review.Dec 7 2023, 5:10 PM

thiemowmde closed this task as Resolved.Dec 13 2023, 11:11 AM

thiemowmde closed subtask T351629: Get a usage baseline for gadgets conflicting with Reference Previews as Resolved.

thiemowmde closed subtask T351314: Update the list of ReferenceTooltips and NavigationPopups gadgets as Resolved.

Stang unsubscribed.Dec 16 2023, 10:33 PM

WMDE-Fisch closed subtask T347758: Replace the Reference Previews Grafana board with a Superset board fitting our needs as Resolved.Dec 20 2023, 12:41 PM