Page MenuHomePhabricator
Create Task
Maniphest T277641

Collect PrefUpdate events for reference previews, remove for page previews
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Add the new reference previews preference to the inclusion list for tracking in WikimediaEvents, using the PrefUpdate schema. Remove the page previews (merged) preference added in T276328: Collect PrefUpdate events for page previews from the list.

Don't bother with aggregation yet.

  • Track logged-in user changes to the reference previews preference
  • Add an event stream for counting anonymous user enables and disables.

Details

SubjectRepoBranchLines +/-
Track anonymous enables/disables of reference previewsmediawiki/extensions/Popupsmaster+10 -5
ReferencePreviewsPopups: Track anonymous enables/disablesschemas/event/secondarymaster+377 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lena_WMDE created this task.Mar 17 2021, 9:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2021, 9:03 AM
Lena_WMDE added projects: Reference Previews, WMDE-TechWish.Mar 17 2021, 9:04 AM
Lena_WMDE moved this task from Backlog to In preparation on the Reference Previews board.Mar 17 2021, 9:17 AM
Lena_WMDE updated the task description. (Show Details)Mar 17 2021, 9:21 AM
Lena_WMDE edited projects, added WMDE-TechWish-Sprint-2021-03-17; removed WMDE-TechWish.Mar 17 2021, 11:11 AM
Lena_WMDE moved this task from In preparation to Doing on the Reference Previews board.
Lena_WMDE added a subtask: T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users.Mar 17 2021, 12:51 PM
Lena_WMDE added a parent task: T271206: Enable RefPreviews on first wikis.
awight set the point value for this task to 1.Mar 24 2021, 2:03 PM
awight updated the task description. (Show Details)Mar 24 2021, 2:15 PM
awight changed the point value for this task from 1 to 2.
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-03-31.Mar 31 2021, 8:08 AM
Andrew-WMDE claimed this task.Apr 1 2021, 7:46 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-31 board.
gerritbot added a comment.Apr 1 2021, 12:22 PM

Change 676334 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[schemas/event/secondary@master] ReferencePreviewsPopups: Track anonymous enables/disables

https://gerrit.wikimedia.org/r/676334

gerritbot added a project: Patch-For-Review.Apr 1 2021, 12:22 PM
gerritbot added a comment.Apr 1 2021, 12:25 PM

Change 676335 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/Popups@master] Track anonymous enables/disables of reference previews

https://gerrit.wikimedia.org/r/676335

gerritbot added a comment.Apr 1 2021, 12:34 PM

Change 676334 merged by jenkins-bot:

[schemas/event/secondary@master] ReferencePreviewsPopups: Track anonymous enables/disables

https://gerrit.wikimedia.org/r/676334

Andrew-WMDE added a comment.Apr 1 2021, 12:36 PM

Tracking the user preference popupsreferencepreviews (i.e. logged in users) is already being done in WikimediaEvents

Andrew-WMDE updated the task description. (Show Details)Apr 1 2021, 12:37 PM
Andrew-WMDE moved this task from Doing to Watching (Stalled) on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 1 2021, 2:29 PM
lilients_WMDE moved this task from Watching (Stalled) to Sprint Backlog on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 6 2021, 1:11 PM
Andrew-WMDE moved this task from Sprint Backlog to Watching (Stalled) on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 8 2021, 7:35 AM
awight subscribed.Apr 12 2021, 7:15 AM

I think this task is marked "stalled" because it's waiting for a final implementation of T277639. I'll set up a task dependency to help make that explicit.

awight added a subtask: T277639: Settings pop up for RefPreviews and Page Previews.Apr 12 2021, 7:16 AM
Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-04-14.Apr 14 2021, 11:05 AM
Lena_WMDE changed the point value for this task from 2 to 1.
Andrew-WMDE moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 14 2021, 11:06 AM
gerritbot added a comment.Apr 15 2021, 1:24 PM

Change 676335 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Track anonymous enables/disables of reference previews

https://gerrit.wikimedia.org/r/676335

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 15 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 15 2021, 2:10 PM
awight added a comment.Apr 16 2021, 7:22 AM

Do we want to track how often the anonymous preferences popup is opened?

Lena_WMDE added a comment.Apr 16 2021, 7:45 AM

Thanks for asking @awight. I don't think it's necessary - for me enable/disable rates are enough.

lilients_WMDE moved this task from Review to Done on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 19 2021, 2:56 PM
lilients_WMDE moved this task from Done to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 27 2021, 8:42 AM
Lena_WMDE closed subtask T277639: Settings pop up for RefPreviews and Page Previews as Resolved.Apr 28 2021, 8:05 AM
Lena_WMDE closed subtask T277640: Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users as Resolved.
Lena_WMDE closed this task as Resolved.Apr 28 2021, 8:07 AM
awight updated the task description. (Show Details)Apr 28 2021, 8:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits