Page MenuHomePhabricator
Create Task
Maniphest T351708

Cleanup beta feature code in the ReferencePreviews and related
Open, Needs TriagePublic
Actions

Description

After the successful deploy we should make sure the code gets cleaned up that made it possible that Reference Previews is a beta feature.

Acceptance criteria

  • Remove beta feature related code in the Popups extension
  • Remove beta feature related code in the mediawiki-config repo
  • Remove beta feature related code that might be set for CI

These config patches should be added to the https://wikitech.wikimedia.org/wiki/Deployments calendar. One dev from our team will add their IRC nick to the deployment entry, then commit to being available in IRC during the window.

Details

SubjectRepoBranchLines +/-
Remove wgPopupsReferencePreviews now that it defaults to trueoperations/mediawiki-configmaster+0 -13
Remove BetaFeature code related to ReferencePreviewsoperations/mediawiki-configmaster+0 -6
Remove BetaFeature dependency for the Popups extensionintegration/configmaster+2 -2
Remove all BetaFeature code from ReferencePreviewsmediawiki/extensions/Popupsmaster+63 -267
Fix confusing constant names in PHPmediawiki/extensions/Popupsmaster+10 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Nov 21 2023, 12:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2023, 12:55 PM
WMDE-Fisch mentioned this in T282999: Enable Reference Previews on all wikis using the Popups extension, on Nov 21.Nov 21 2023, 12:56 PM
gerritbot added a comment.Nov 21 2023, 12:57 PM

Change 971897 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Popups@master] Remove all BetaFeature code from ReferencePreviews

https://gerrit.wikimedia.org/r/971897

gerritbot added a project: Patch-For-Review.Nov 21 2023, 12:57 PM
WMDE-Fisch renamed this task from Cleanup beta feature code in the ReferencePreviews extension to Cleanup beta feature code in the ReferencePreviews and related.Nov 22 2023, 7:51 AM
WMDE-Fisch updated the task description. (Show Details)
gerritbot added a comment.Nov 22 2023, 7:51 AM

Change 976650 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[operations/mediawiki-config@master] Remove BetaFeature code related to ReferencePreviews

https://gerrit.wikimedia.org/r/976650

Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2023-11-22.Nov 22 2023, 9:10 AM
Tobi_WMDE_SW moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-11-22 board.
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Nov 22 2023, 9:19 AM
gerritbot added a comment.Nov 22 2023, 12:42 PM

Change 976697 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[integration/config@master] Remove BetaFeature dependency for the Popups extension

https://gerrit.wikimedia.org/r/976697

gerritbot added a comment.Nov 24 2023, 12:12 PM

Change 977179 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Fix confusing constant names in PHP

https://gerrit.wikimedia.org/r/977179

gerritbot added a comment.Nov 24 2023, 2:37 PM

Change 977179 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix confusing constant names in PHP

https://gerrit.wikimedia.org/r/977179

gerritbot added a comment.Nov 24 2023, 2:37 PM

Change 971897 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove all BetaFeature code from ReferencePreviews

https://gerrit.wikimedia.org/r/971897

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 24 2023, 3:00 PM
gerritbot added a comment.Nov 27 2023, 8:55 AM

Change 976697 merged by jenkins-bot:

[integration/config@master] Remove BetaFeature dependency for the Popups extension

https://gerrit.wikimedia.org/r/976697

Stashbot added a comment.Nov 27 2023, 8:56 AM

Mentioned in SAL (#wikimedia-releng) [2023-11-27T08:56:27Z] <hashar> Reloaded Zuul for https://gerrit.wikimedia.org/r/976697 "Remove BetaFeature dependency for the Popups extension" - T351708

awight moved this task from Tech Review to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2023-11-22 board.Nov 28 2023, 3:11 PM
gerritbot added a comment.Dec 6 2023, 12:33 PM

Change 978035 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] Remove wgPopupsReferencePreviews now that it defaults to true

https://gerrit.wikimedia.org/r/978035

thiemowmde added a project: WMDE-TechWish-Sprint-2023-12-06.Dec 6 2023, 12:33 PM
awight updated the task description. (Show Details)Dec 6 2023, 2:32 PM
Jdlrobson subscribed.Dec 7 2023, 4:52 PM
awight subscribed.Dec 14 2023, 12:28 PM

Next step is to schedule a config deployment window.

WMDE-Fisch assigned this task to MareikeHeuerWMDE.Dec 19 2023, 10:02 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-12-06 board.
gerritbot added a comment.Dec 20 2023, 2:32 PM

Change 976650 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove BetaFeature code related to ReferencePreviews

https://gerrit.wikimedia.org/r/976650

gerritbot added a comment.Dec 20 2023, 2:32 PM

Change 978035 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wgPopupsReferencePreviews now that it defaults to true

https://gerrit.wikimedia.org/r/978035

Stashbot added a comment.Dec 20 2023, 2:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-20T14:33:11Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:976650|Remove BetaFeature code related to ReferencePreviews (T351708)]], [[gerrit:978035|Remove wgPopupsReferencePreviews now that it defaults to true (T351708)]]

Stashbot added a comment.Dec 20 2023, 2:35 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-20T14:35:02Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde and awight and wmde-fisch: Backport for [[gerrit:976650|Remove BetaFeature code related to ReferencePreviews (T351708)]], [[gerrit:978035|Remove wgPopupsReferencePreviews now that it defaults to true (T351708)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Dec 20 2023, 2:43 PM

Mentioned in SAL (#wikimedia-operations) [2023-12-20T14:43:27Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:976650|Remove BetaFeature code related to ReferencePreviews (T351708)]], [[gerrit:978035|Remove wgPopupsReferencePreviews now that it defaults to true (T351708)]] (duration: 10m 16s)

WMDE-Fisch removed MareikeHeuerWMDE as the assignee of this task.Dec 20 2023, 3:06 PM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Doing to Done on the WMDE-TechWish-Sprint-2023-12-06 board.
WMDE-Fisch added a subscriber: MareikeHeuerWMDE.
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2023, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL