Page MenuHomePhabricator
Create Task
Maniphest T266288

[betalabs] Uncaught TypeError: Cannot read property 'nextSibling' of null - when Reply to WikiLove
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. On betalabs, enable WikiLove (Special:Preferenes-Editing).
  2. Post WikiLove message on a user page. The WikiLove messages will have a reply link:

Screen Shot 2020-10-22 at 3.20.06 PM.png (424×679 px, 139 KB)

  1. Click on the reply link - the link disappear and no text box is open. The Console will display the following error:
Uncaught TypeError: Cannot read property 'nextSibling' of null
at Object.addListItem
at CommentController.js.CommentController.setup 
at CommentController.js.CommentController.onReplyLinkClick
at HTMLAnchorElement.dispatch
at HTMLAnchorElement.elemData.handle

and the warning

jQuery.Deferred exception: Cannot read property 'nodeType' of null TypeError: Cannot read property 'nodeType' of null

Example page: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:ET10#A_kitten_for_you!

Details

SubjectRepoBranchLines +/-
Add test case for trailing void tags (<br>)mediawiki/extensions/DiscussionToolsmaster+32 -7
Fix trying to insert start/end markers in impossible locationsmediawiki/extensions/DiscussionToolsmaster+45 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Oct 22 2020, 10:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2020, 10:25 PM
matmarex added a project: DiscussionTools.EditedOct 23 2020, 12:49 AM
matmarex subscribed.

Seems to be a problem with server-side reply links; there is a marker for the start of the comment (e.g. <span data-mw-comment-start="c|ET13|2020-10-22T22:11:00.000Z|A_kitten_for_you!_2"></span>), but a matching marker for the end (data-mw-comment-end) is nowhere to be found. So we get a null and these exceptions.

matmarex added a comment.Oct 23 2020, 12:57 AM

Okay, I see what is happening… We insert the end marker inside the <br style="clear: both;"/> node, which is of course impossible in HTML. Oof…

matmarex updated the task description. (Show Details)Oct 23 2020, 1:04 AM
matmarex updated the task description. (Show Details)
Ryasmeen subscribed.Oct 26 2020, 5:29 PM
• jbolorinos-ctr subscribed.Oct 26 2020, 5:29 PM
matmarex added a comment.Dec 5 2020, 9:29 PM

I wanted to fix this and discovered that it's already fixed, as a result of the changes in rEDTOd0ae6c4e445e: Skip end marker "forward" until a block tag is reached. We should add a unit test for this case though.

gerritbot added a comment.Dec 9 2020, 11:01 PM

Change 647381 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add test case for trailing void tags (<br>)

https://gerrit.wikimedia.org/r/647381

gerritbot added a project: Patch-For-Review.Dec 9 2020, 11:01 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Dec 9 2020, 11:02 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex mentioned this in T270009: Discussion Tools causes TemplateStyles to be empty in certain cases.Dec 14 2020, 1:12 AM
gerritbot added a comment.Dec 14 2020, 5:00 PM

Change 649413 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix trying to insert start/end markers in impossible locations

https://gerrit.wikimedia.org/r/649413

matmarex added a comment.Dec 14 2020, 5:16 PM

While writing the test case, I found that it's not actually fixed in all cases, and this patch fixes it for real.

gerritbot added a comment.Dec 14 2020, 8:37 PM

Change 649413 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix trying to insert start/end markers in impossible locations

https://gerrit.wikimedia.org/r/649413

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 14 2020, 9:00 PM
JTannerWMF moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Dec 16 2020, 6:41 PM
Ryasmeen added a project: Editing QA.Dec 16 2020, 8:46 PM
Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Dec 17 2020, 9:33 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Dec 24 2020, 2:31 AM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 24 2020, 2:31 AM
gerritbot added a comment.Jan 4 2021, 9:41 PM

Change 647381 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add test case for trailing void tags (<br>)

https://gerrit.wikimedia.org/r/647381

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Jan 4 2021, 10:00 PM
matmarex mentioned this in T301427: Discussion tools not working on some pages with videos when using "New video player" beta feature (Uncaught TypeError: startMarker is null).Feb 10 2022, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits