Page MenuHomePhabricator

Change mobile editor preference to a database-stored preference
Closed, ResolvedPublic

Description

This task is about switching how/where peoples' mobile editor preferences are stored from localStorage to database storage.

Test instructions

Re-test the failing cases @Ryasmeen described in T261423#6569890.

Note:

  • The preference is stored in the database if you are logged in. If you are logged out we continue to use localStorage.
  • The preference is only changed when you switch editors.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 636651 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Create a database preference for preferred editor

https://gerrit.wikimedia.org/r/636651

Esanders moved this task from Upcoming to Code Review on the Editing-team (Kanban Board) board.

@ppelberg On looking at the code further, it appears the preference is only set when you switch editors. We could change this to be whenever the editor is loaded instead (which is what desktop does). For now the patch just implements database storage.

Change 636651 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Create a database preference for preferred editor

https://gerrit.wikimedia.org/r/636651

matmarex added a project: Editing QA.
matmarex subscribed.

This can be QAed once @Esanders looks at T261423

T261423 is now in QA as well.

@Esanders: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

matmarex assigned this task to Esanders.

I think this should have been closed in 2021. It definitely works correctly in the common case. I don't think we're going to be able to investigate these edge cases.