Page MenuHomePhabricator

Change mobile editor preference to a database-stored preference
Open, Needs TriagePublic

Description

This task is about switching how/where peoples' mobile editor preferences are stored from localStorage to database storage.

Test instructions

Re-test the failing cases @Ryasmeen described in T261423#6569890.

Note:

  • The preference is stored in the database if you are logged in. If you are logged out we continue to use localStorage.
  • The preference is only changed when you switch editors.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 23 2020, 12:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 636651 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Create a database preference for preferred editor

https://gerrit.wikimedia.org/r/636651

Esanders updated the task description. (Show Details)Oct 27 2020, 12:51 PM

@ppelberg On looking at the code further, it appears the preference is only set when you switch editors. We could change this to be whenever the editor is loaded instead (which is what desktop does). For now the patch just implements database storage.

@ppelberg to file task for what @Esanders is describing in T266304#6581300

Change 636651 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Create a database preference for preferred editor

https://gerrit.wikimedia.org/r/636651