Page MenuHomePhabricator

Remove beta survey announcement from wikifeeds
Closed, ResolvedPublic

Description

Before 6.7.3 goes out in App Store but after our release candidate smoke test, we need to turn off the beta survey announcement that's currently returning from wikifeeds. This announcement was originally turned on as a part of https://phabricator.wikimedia.org/T266274.

I think the best way to do this is to adjust the startTime and endTime to some date in the past. That should prevent the server from returning the announcement entirely. We will turn the announcement back on ~1 week after 6.7.3 goes out as a part of https://phabricator.wikimedia.org/T268173.

Event Timeline

JMinor raised the priority of this task from Medium to High.Nov 23 2020, 7:32 PM

Change 643098 had a related patch set uploaded (by Matt Cleinman; owner: Matt Cleinman):
[mediawiki/services/wikifeeds@master] Turn off Article as a Living Doc feature

https://gerrit.wikimedia.org/r/643098

Change 643098 merged by jenkins-bot:
[mediawiki/services/wikifeeds@master] Turn off Article as a Living Doc feature

https://gerrit.wikimedia.org/r/643098

Any need to wait before deploying this, or can it happen anytime today?

No need to wait for deploying this one, @Mholloway. Thanks!

@Mholloway in fact, we'd prefer it get deployed today if possible. Once this is deployed, we'll release the next version of the iOS app to the public.

Thanks, @MattCleinman. @MSantos just deployed the change. Looks like now we just need to purge the cache or wait for the current content to age out. (I'm still seeing the survey entry in the enwiki announcements response.)

Thanks @Mholloway. Looks like it's still returning the survey. How long will it take the cache to age out? If it won't be in the next couple hours, would it be possible to manually purge the cache?

Done. I've also proposed a change to announcements endpoint cache controi headers that should eliminate the need for manual purges going forward.

https://gerrit.wikimedia.org/r/c/mediawiki/services/wikifeeds/+/643350

JMinor claimed this task.
JMinor subscribed.

Thanks for the assist/cache improvement @Mholloway