Page MenuHomePhabricator
Create Task
Maniphest T268315

Investigation: Check core's conflict detection for changes possibly causing more conflicts
Open, Needs TriagePublic
Actions

Description

We keep getting reports where users claim they would run into more edit conflicts recently. These reports are not about "conflicts with myself" (see T222805 as well as T72163 for that). More than one user said the conflict was with an edit that was made hours before.

Collection of possibly related user reports (please expand):

To do:

  • Check tickets in T72163 and MediaWiki-Page-editing (there is an "Edit conflict" column) for closed or in-progress tickets that might be related to conflict detection.
  • Check the Git logs for the relevant code. Are there recent changes that could be related?
  • Check the conflict audit logs for any clues.

Related Objects

Event Timeline

thiemowmde created this task.Nov 20 2020, 9:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2020, 9:06 AM
thiemowmde updated the task description. (Show Details)Nov 24 2020, 7:50 AM
WMDE-Fisch added a subscriber: daniel.Nov 26 2020, 10:13 AM

@daniel I vaguely remember something popping up about changes to the edit conflict detection lately in combination with you - can you confirm / deny? :-)

Lena_WMDE added a project: WMDE-TechWish.Nov 26 2020, 10:19 AM
Lena_WMDE moved this task from Proposed to Maintenance Backlog on the WMDE-TechWish board.
awight updated the task description. (Show Details)Nov 26 2020, 10:22 AM
awight added a comment.Nov 26 2020, 10:31 AM

I remember some talk about removing the "suppress edit conflict with self" logic but I see it's still there.

Other changes of interest, probably not at fault:

daniel added a comment.Nov 26 2020, 10:51 AM
In T268315#6650900, @WMDE-Fisch wrote:

@daniel I vaguely remember something popping up about changes to the edit conflict detection lately in combination with you - can you confirm / deny? :-)

See discussion on T175745: Do not overwrite edits when conflicting with self. There seems to be rough consensus among tech folks that this should go away, but there's nobody driving this from the product side. OTOH, this can be fixed by simply deleting 100 lines of code in two files or so, maybe someone (tm) can JFDI...

Lena_WMDE added a comment.Dec 9 2020, 2:09 PM

Thanks for the note @daniel. Unfortunately it's not in the scope of this project to work on the conflict detection algorithm, so we'll have to pass on that as well.

TechWish team, please note that making the following change is explicitly not in scope for the work on TwoColConflict.

See discussion on T175745: Do not overwrite edits when conflicting with self. There seems to be rough consensus among tech folks that this should go away, but there's nobody driving this from the product side. OTOH, this can be fixed by simply deleting 100 lines of code in two files or so, maybe someone (tm) can JFDI...

If changes like this have happened or will happen, they are interesting to note here though since it would result in more conflicts occurring.

Lena_WMDE updated the task description. (Show Details)Dec 14 2020, 11:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL